[No QA] [TEST - DO NOT MERGE] Add Payments hub demo structure for help site restructuring#92620
[No QA] [TEST - DO NOT MERGE] Add Payments hub demo structure for help site restructuring#92620stephanieelliott wants to merge 3 commits into
Conversation
Introduce placeholder Payments-Reimbursement-and-Banking hub with nested sections, archive wallet-and-payments for the demo, and hide the old hub from navigation. Co-authored-by: Cursor <cursoragent@cursor.com>
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
melvin-bot
Bot
requested review from
johncschuster and
mjasikowski
and removed request for
a team
|
@mjasikowski @johncschuster One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| title: Learn how Payments, Reimbursement and Banking work in Expensify | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, payments, reimbursement, banking] | ||
| order: 1 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3. Every article must include it to define the audience, covered workflow, and explicit exclusions. Example:
internalScope: Audience is [workspace admins and members]. Covers [payments and reimbursement overview], does not cover [specific bank account setup].
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| title: Learn how Payments, Reimbursement and Banking work in Expensify | |||
| description: Demo article for help site restructuring preview. | |||
There was a problem hiding this comment.
Non-compliant description: Per HELP_AUTHORING_GUIDELINES.md Section 3, the description must be a "1-2 sentence summary of outcome" that reflects real search intent. "Demo article for help site restructuring preview" is a placeholder that does not describe the article's purpose for SEO or AI retrieval.
| --- | ||
| <div id="new-expensify" markdown="1"> | ||
|
|
||
| _Demo placeholder — help site restructuring preview._ |
There was a problem hiding this comment.
Missing required article structure: Per HELP_AUTHORING_GUIDELINES.md Sections 4 and 6, every article must include: (1) exactly one # heading matching the article title, (2) task-based ## sections, and (3) at least one "How to..." heading for AI retrieval optimization. This article has no headings or substantive content beyond the placeholder line.
| title: Learn about getting reimbursed in Expensify | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, reimbursement] | ||
| order: 1 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3. Add it to define the target audience, covered workflow, and explicit exclusions.
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| title: Learn about getting reimbursed in Expensify | |||
| description: Demo article for help site restructuring preview. | |||
There was a problem hiding this comment.
Non-compliant description: The description must summarize the article's outcome for SEO and AI retrieval, not serve as a placeholder notice. Per HELP_AUTHORING_GUIDELINES.md Section 3.
| title: Set up a personal bank account | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, personal bank account] | ||
| order: 2 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| title: Set up a personal bank account | |||
| description: Demo article for help site restructuring preview. | |||
There was a problem hiding this comment.
Non-compliant description: The description must summarize the article's outcome, not serve as a placeholder. Per HELP_AUTHORING_GUIDELINES.md Section 3.
| title: Learn about managing bank accounts in Expensify | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, bank accounts] | ||
| order: 1 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
| title: Delete your personal bank account | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, delete bank account] | ||
| order: 2 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
| title: Share your business bank account | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, share bank account] | ||
| order: 3 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
| title: Learn about reimbursing employees in Expensify | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, reimburse employees] | ||
| order: 1 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
| title: Learn about reimbursing employees internationally | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, international reimbursement] | ||
| order: 1 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
| title: Set up a CAD business bank account | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, Canada, CAD] | ||
| order: 4 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
| title: Set up a SGD business bank account | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, Singapore, SGD] | ||
| order: 5 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
HelpDot Documentation ReviewOverall AssessmentThis PR restructures the "Wallet & Payments" hub into a new "Payments, Reimbursement & Banking" hub with a deeper nested hierarchy. It archives 17 existing articles into Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Since all new articles are structural placeholders with no substantive content, a full content-quality review (step formatting, cross-linking, FAQ structure, heading hierarchy within articles) is not applicable at this stage. Scores reflect the metadata and structural aspects that can be evaluated now. |
| title: Set up a UK/GBP business bank account | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, UK, GBP] | ||
| order: 2 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
| title: Set up an AUS business bank account | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, Australia] | ||
| order: 3 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
| title: Learn about reimbursing employees in the US | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, US reimbursement] | ||
| order: 1 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
| title: Set up a US business bank account | ||
| description: Demo article for help site restructuring preview. | ||
| keywords: [demo, US business bank account] | ||
| order: 2 |
There was a problem hiding this comment.
Missing required YAML field: The internalScope field is mandatory per HELP_AUTHORING_GUIDELINES.md Section 3.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ba37c0d14
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| - href: wallet-and-payments | ||
| title: Wallet & Payments | ||
| - href: Payments-Reimbursement-and-Banking |
There was a problem hiding this comment.
When this docs deploys, existing bookmarks, search results, and still-present internal links that point at /new-expensify/hubs/wallet-and-payments or /articles/new-expensify/wallet-and-payments/... will 404 because the hub href is changed here and the old article files were moved under docs/_demo-hidden (which Jekyll does not publish); I also checked docs/redirects.csv and there is no new mapping for these URLs. Please add redirects or keep aliases for the old hub and article URLs before switching the route.
Useful? React with 👍 / 👎.
Keep existing article URLs working without redirects by bringing back wallet-and-payments next to Payments-Reimbursement-and-Banking. Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Move Payments hub first on New Expensify, use custom titles and order via _section.yml, read article titles from front matter, and center section cards by matching article-card styling. Co-authored-by: Cursor <cursoragent@cursor.com>
stephanieelliott
added
the
HelpDot
2 participants
Introduce placeholder Payments-Reimbursement-and-Banking hub with nested sections, archive wallet-and-payments for the demo, and hide the old hub from navigation.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari