[No QA] Docs updates for E/A#92029 link travel expense to its trip#92632
[No QA] Docs updates for E/A#92029 link travel expense to its trip#92632MelvinBot wants to merge 1 commit into
Conversation
Adds a section to "How Expensify and Expensify Travel Connect" covering the new Trip row in a travel expense's details that opens the related trip. Co-authored-by: Ishpaul Singh <ishpaul777@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://dac5df7f.helpdot.pages.dev ⚡️ Updated articles: |
|
@blimpich can you please review if we need this and open for review |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a focused new section ("How to open the related trip from a travel expense") to the Expensify Travel integration article, along with three new keywords in the YAML frontmatter. The changes are well-scoped, clearly written, and follow governance conventions closely. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review assessed only the proposed changes in the diff, not pre-existing content. |
|
|
||
| 1. Open the travel expense to view its details (in a side panel on web, or a details screen on mobile). | ||
| 2. Select the **Trip** row, which shows the trip name. | ||
| 3. The related trip opens, where you can review the bookings and expenses for that trip. |
There was a problem hiding this comment.
Step formatting: Step 3 describes a result, not a user action. Per the authoring guidelines (Section 5), all numbered steps must be "action-oriented." Consider converting this into a non-numbered outcome line or folding the result into step 2.
Suggested revision:
| 3. The related trip opens, where you can review the bookings and expenses for that trip. | |
| 2. Select the **Trip** row, which shows the trip name. The related trip opens, where you can review the bookings and expenses for that trip. |
Or keep step 3 as a plain sentence outside the numbered list (e.g., "The related trip opens, where you can review...").
Explanation of Change
Help site docs update for the Trip row added to the expense details view in Expensify/App#92029.
That PR adds a Trip row to a travel expense's details (
MoneyRequestView) in New Expensify. The row appears on any expense created from an Expensify Travel booking and links to the related trip room.This docs PR adds a focused, task-based section — How to open the related trip from a travel expense — to the existing How Expensify and Expensify Travel Connect article, since that article already explains how travel bookings and expenses are connected. The section documents that selecting the Trip row in the expense details opens the related trip, and clarifies the row only appears on travel-booked expenses.
Authoring notes:
travel.tripinsrc/languages/en.ts).docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: single#title preserved, new##heading is task-based and feature-specific, exact bolded UI label, and a non-rendered screenshot placeholder.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/638596
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
QA
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
@ishpaul777, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.