Skip to content

[No QA] Docs updates for E/A#92029 link travel expense to its trip#92632

Open
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsTripRowTravelExpense
Open

[No QA] Docs updates for E/A#92029 link travel expense to its trip#92632
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsTripRowTravelExpense

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Explanation of Change

Help site docs update for the Trip row added to the expense details view in Expensify/App#92029.

That PR adds a Trip row to a travel expense's details (MoneyRequestView) in New Expensify. The row appears on any expense created from an Expensify Travel booking and links to the related trip room.

This docs PR adds a focused, task-based section — How to open the related trip from a travel expense — to the existing How Expensify and Expensify Travel Connect article, since that article already explains how travel bookings and expenses are connected. The section documents that selecting the Trip row in the expense details opens the related trip, and clarifies the row only appears on travel-booked expenses.

Authoring notes:

  • Verified the UI label is Trip (from travel.trip in src/languages/en.ts).
  • Followed docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: single # title preserved, new ## heading is task-based and feature-specific, exact bolded UI label, and a non-rendered screenshot placeholder.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/638596

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

QA

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.


@ishpaul777, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Adds a section to "How Expensify and Expensify Travel Connect" covering
the new Trip row in a travel expense's details that opens the related trip.

Co-authored-by: Ishpaul Singh <ishpaul777@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team June 4, 2026 08:02
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 4, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#92029 link travel expense to its trip [No QA] Docs updates for E/A#92029 link travel expense to its trip Jun 4, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jun 4, 2026

A preview of your ExpensifyHelp changes have been deployed to https://dac5df7f.helpdot.pages.dev ⚡️

Updated articles:

@ishpaul777
Copy link
Copy Markdown
Contributor

@blimpich can you please review if we need this and open for review

@ishpaul777 ishpaul777 requested a review from blimpich June 4, 2026 23:21
@blimpich blimpich marked this pull request as ready for review June 4, 2026 23:29
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Jun 4, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @CortneyOfstad

@melvin-bot melvin-bot Bot requested review from CortneyOfstad and removed request for a team June 4, 2026 23:29
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Jun 4, 2026

@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

HelpDot Documentation Review

Overall Assessment

This PR adds a focused new section ("How to open the related trip from a travel expense") to the Expensify Travel integration article, along with three new keywords in the YAML frontmatter. The changes are well-scoped, clearly written, and follow governance conventions closely.

Scores Summary

  • Readability: 9/10 - The new section is concise, scannable, and uses clear numbered steps. The clarifying note after the steps ("The Trip row only appears on expenses created from an Expensify Travel booking") effectively sets expectations. Minor improvement possible in step 1 by providing explicit navigation to the expense rather than the general "Open the travel expense."
  • AI Readiness: 9/10 - The new heading is task-based with a "How to" prefix and includes the feature name. The three added keywords ("view trip from expense," "Trip row," "open trip from expense") align well with realistic search queries. Note: the existing YAML metadata is missing the required internalScope field per HELP_AUTHORING_GUIDELINES.md Section 3, but since that is pre-existing and not part of this diff, it is not scored here.
  • Style Compliance: 10/10 - The Trip UI element is correctly bolded. The section heading follows task-based conventions. The screenshot placeholder uses the exact required HTML comment format from HELP_AUTHORING_GUIDELINES.md Section 8. Platform context (web vs. mobile) is provided clearly in step 1.

Key Findings

  • The new section follows the single-workflow principle well -- it addresses exactly one task (navigating from a travel expense to its associated trip).
  • Step formatting is sequential, action-oriented, and aligned with UI flow per Section 5 of the authoring guidelines.
  • The screenshot placeholder is properly formatted as a non-rendered HTML comment with Suggestion, Location, and Purpose fields.
  • Keywords additions are practical and match real user search intent.
  • Pre-existing note (not scored): the file's YAML frontmatter is missing the mandatory internalScope field. Consider adding it in a follow-up.

Recommendations

  1. Minor (step 1): Consider adding navigation context to step 1. Currently it reads "Open the travel expense to view its details," which assumes the user already knows how to locate it. A brief navigation cue (e.g., referencing the report or search) would improve self-containedness.
  2. Follow-up: Add the missing internalScope YAML field to the article's frontmatter in a separate PR to bring the full article into compliance with Section 3 of the authoring guidelines.

Files Reviewed

  • docs/articles/travel/getting-started/How-Expensify-and-Expensify-Travel-Connect.md - New section and keyword additions are well-structured and governance-compliant.

Note: This review assessed only the proposed changes in the diff, not pre-existing content.


1. Open the travel expense to view its details (in a side panel on web, or a details screen on mobile).
2. Select the **Trip** row, which shows the trip name.
3. The related trip opens, where you can review the bookings and expenses for that trip.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step formatting: Step 3 describes a result, not a user action. Per the authoring guidelines (Section 5), all numbered steps must be "action-oriented." Consider converting this into a non-numbered outcome line or folding the result into step 2.

Suggested revision:

Suggested change
3. The related trip opens, where you can review the bookings and expenses for that trip.
2. Select the **Trip** row, which shows the trip name. The related trip opens, where you can review the bookings and expenses for that trip.

Or keep step 3 as a plain sentence outside the numbered list (e.g., "The related trip opens, where you can review...").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants