[No QA] Docs updates for E/A#91725 surface Signer info needed Home task#92634
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#91725 surface Signer info needed Home task#92634MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
…gner steps Co-authored-by: Dilshod Bunyodov <dilshodmackbook-sketch@users.noreply.github.com>
51 tasks
Contributor
Contributor
|
Reviewed the 5 updated help articles — the added Note block accurately reflects the behavior shipped in #91725. UI labels in the note (Signer info needed, Time sensitive, Begin, Home) match the in-app strings in I don't have permission to edit the PR description or flip it out of draft, so leaving the Tests / QA copy here for a maintainer to drop in and mark Tests
QA
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
PR #91725 added a new Signer info needed task to the Time sensitive section of the Home page, surfacing pending signer-info actions for global reimbursement bank accounts. When a workspace admin designates a Director or Senior Officer to act as the signer, that person now sees a task on their Home page and can select Begin to enter their information.
This PR updates the global reimbursement help articles so the documented signer/director step reflects this new entry point. A short note was added to each country guide at the point where the designated signer is told they'll be notified.
Files updated:
Global-Reimbursement-United-States.mdGlobal-Reimbursement-Europe.mdGlobal-Reimbursement-Canada.mdGlobal-Reimbursement-United-Kingdom.mdGlobal-Reimbursement-Australia.mdUI labels were verified against
src/languages/en.ts:homePage.timeSensitiveSection.enterSignerInfo.title)homePage.timeSensitiveSection.title)homePage.forYouSection.begin)Fixed Issues
$ #90996
Related PR: #91725
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
QA
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
@dilshodmackbook-sketch, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.