Skip to content

Decompose ReportActionsList: 6#93694

Merged
rlinoz merged 27 commits into
Expensify:mainfrom
callstack-internal:decompose/ral-6
Jun 29, 2026
Merged

Decompose ReportActionsList: 6#93694
rlinoz merged 27 commits into
Expensify:mainfrom
callstack-internal:decompose/ral-6

Conversation

@LukasMod

@LukasMod LukasMod commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

part of the ReportActionsList decomposition series (#88320)

This splits the old ReportActionsView into three pieces: a route-only orchestrator that decides what to render, a skeleton guard that owns the data pipeline and gates rendering, and a hook-driven body that renders the chat list. There are no user-facing behavior changes. This is a structural refactor.

Changes

  • New src/pages/inbox/ReportActions.tsx: a route-only orchestrator. It owns the coarse branching: the early skeleton states, the choice between the money-request table and the chat list, and mounting UserTypingEventListener. The app-load skeleton is hoisted here so the body's hooks never run during app boot — except for Concierge, which is excluded so the body stays mounted under that skeleton and can seed its session, matching the old ReportActionsView.
  • New src/hooks/useReportActionsListModel.ts: the single read-and-derive pipeline for the list. It runs the subscriptions and derivations once (sort, paginate, visibility, concierge) and returns three projections: readinessSignals (kept off the context, feeds the skeleton decision), state (the render payload), and actions (the command handles: load older, load newer, show previous messages).
  • New src/pages/inbox/report/ReportActionsSkeletonGuard.tsx: owns useReportActionsListModel, makes the skeleton-versus-content decision (computeReportActionsSkeletonState), runs the effects that must fire while the skeleton shows (copy-selection, pending-concierge, concierge-session start, cold-open telemetry), and provides state and actions to the body. It is modeled on ReportNotFoundGuard: it returns early with the skeleton before the body mounts, so the body's hooks and effects never run during the skeleton phase.
  • New src/pages/inbox/report/ReportActionsListContext.tsx: splits the pipeline output into two contexts. ReportActionsListStateContext carries the render state that changes often, and it is the only slice that drives list re-renders. ReportActionsListActionsContext carries the command handles, which keep a stable identity, so a consumer that reads only the handles does not re-render when new actions arrive. This follows the State/Actions split that ConciergeSessionContext already uses.
  • src/pages/inbox/report/ReportActionsList.tsx (the body) is now hook-driven. Its props shrink to {reportID, onLayout?}. It reads the pipeline output from the two contexts and holds only the UI-close hooks (useUnreadMarker, useMarkAsRead, useReportActionsScroll). Those hooks cannot run while the skeleton shows, because the guard mounts the body only once content is ready.
  • New src/hooks/useMarkOpenReportEndOnSkeleton.ts: a shared hook that closes the open-report telemetry span as a cold open (markOpenReportEnd(report, {warm: false})) the moment a cold-load skeleton appears. It replaces four identical inline effects (the guard, the orchestrator, MoneyRequestReportView, and MoneyRequestReportActionsList).
  • ReportScreen now mounts <ReportActions/> instead of the old wrapper.
  • MoneyRequestReportView mounts the body (ReportActionsList) directly and mounts UserTypingEventListener itself. It does not route through the orchestrator on purpose, because its money-request branching stays where it is, per the blueprint.
  • Deleted: ReportActionsView.tsx, the old 58-line inbox/ReportActionsList.tsx wrapper, and getReportActionsListInitialNumToRender.ts (and its test).

Unit Tests

  • tests/ui/ReportActionsTest.tsx: orchestrator tests for the skeleton states, the choice between the money-request table and the chat list, the typing mount, and the app-load warm: false telemetry.
  • tests/ui/ReportActionsListTest.tsx: body tests for concierge and fine-grained skeleton behavior. It mounts the body directly with a seeded Onyx store.
  • tests/ui/MoneyRequestReportViewTest.tsx: the second consumer. It mounts the body and the typing listener on the chat path, and the table view on the money-request path.
  • tests/perf-test/ReportActionsList.perf-test.tsx: rewritten against the new body surface (see below).

Perf: not a like-for-like regression

The render count increased from 3 to 5 and it has a concrete explanation.
With static props the component rendered straight through in ~3 passes.
With only reportID, it subscribes to many useOnyx keys that resolve asynchronously after mount, that settles triggers a re-renders.

Instability fixed along the way. While reviewing the relocated pipeline I found a real instability: useReportActionsVisibility built its {[reportID]: slice} lookup as an inline computed-key object literal. The React Compiler refuses to memoize a dynamically-keyed object, and pruned memoization of the visible-actions filter that depends on it, so sortedVisibleReportActions got a fresh reference every render. That unstable array flowed into the list context value, re-rendering the list body on every settling subscription. Moving the wrap into reportVisibleActionsSelector (a plain selector useOnyx hands back stably) removed the computed-key literal and let the compiler memoize the filter again. This was a pre-existing instability (on main the same array was passed as an unstable prop into memo(ReportActionsList)), not something the decomposition introduced. It also resolves the review note about the state/actions context values repainting ReportActionsListContent on guard-only re-renders: actions was already referentially stable and the compiler already memoizes state; this one field was the only churn. Verified by useReportActionsListModelStability.test.tsx (state and actions keep the same reference across a guard re-render with unchanged data).

Fixed Issues

$ #89767
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Test 1: Open a regular chat

  1. Open a regular chat (1:1 or group).
  2. Expect: Messages render; no infinite skeleton; can scroll.

Test 2: Deep-link to an old message

  1. Deep-link to an old message (open a link to a specific reportAction).
  2. Expect: Opens scrolled to that message, not the bottom.

Test 3: Open an expense report with multiple transactions

  1. Open an expense report with multiple transactions.
  2. Expect: Shows the table view (MoneyRequestReportActionsList), not the chat list.

Test 4: Open an expense report that renders chat-style

  1. Open an expense report that renders chat-style (no table view).
  2. Expect: Shows the chat list.

Test 5: Open a single expense / transaction-thread report

  1. Open a single expense / transaction-thread report (drill into one transaction inside a money report).
  2. Expect: Chat thread renders below the money-request header.

Test 6: Typing indicator in a 1:1 chat

  1. In a 1:1 chat, have the other party type (or use two sessions).
  2. Expect: "… is typing" appears (route path).

Test 7: Typing indicator in a transaction-thread report

  1. In a transaction-thread report, have someone type.
  2. Expect: Typing indicator appears here too (only if single expense).

Test 8: Open the Concierge DM

  1. Open the Concierge DM.
  2. Expect: Loads without a wrong-content flash

Test 9: Open an unread report

  1. Open an unread report.
  2. Expect: It becomes read (unread badge clears in LHN).

Test 10: Scroll up to load older messages, then back down

  1. Scroll up to load older messages, then back down.
  2. Expect: Older messages load; scrolling to the bottom marks the newest as read.

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
andoird.native.mov
Android: mWeb Chrome
android.chrome.mov
iOS: Native
ios.native.mov
iOS: mWeb Safari
ios.safari.mov
MacOS: Chrome / Safari
web1.mov
web2.mov

@LukasMod LukasMod changed the title [NoQA] decompose ReportActionsList: 6 [WIP] [NoQA] decompose ReportActionsList: 6 Jun 16, 2026
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...equestReportView/MoneyRequestReportActionsList.tsx 63.76% <100.00%> (-0.04%) ⬇️
.../MoneyRequestReportView/MoneyRequestReportView.tsx 54.94% <ø> (+54.94%) ⬆️
src/hooks/useIsReportReadyToDisplay.ts 100.00% <ø> (ø)
src/hooks/useLinkedMessageOfflineLoading.ts 100.00% <100.00%> (ø)
src/hooks/useMarkOpenReportEndOnSkeleton.ts 100.00% <100.00%> (ø)
src/hooks/useReportActionsListModel.ts 100.00% <100.00%> (ø)
src/hooks/useReportActionsScroll.ts 97.87% <ø> (-0.03%) ⬇️
src/hooks/useReportActionsVisibility.ts 94.28% <100.00%> (-0.16%) ⬇️
src/hooks/useStartConciergeSession.ts 100.00% <100.00%> (ø)
src/libs/ReportActionsUtils.ts 78.48% <ø> (ø)
... and 7 more
... and 12 files with indirect coverage changes

@LukasMod LukasMod changed the title [WIP] [NoQA] decompose ReportActionsList: 6 [NoQA] decompose ReportActionsList: 6 Jun 17, 2026
@LukasMod LukasMod changed the title [NoQA] decompose ReportActionsList: 6 Decompose ReportActionsList: 6 Jun 17, 2026
LukasMod added 9 commits June 17, 2026 12:50
Add src/pages/inbox/ReportActions.tsx as the route-only orchestrator that owns
the coarse branching (skeleton / money-request table view / chat list) and
subscribes to only what those branches need. ReportScreen now mounts it instead
of the old 58-LOC inbox/ReportActionsList.tsx wrapper, which is removed.
ReportActionsView stays for now (still used by MoneyRequestReportView) and is
deleted in the next commit.

The app-load skeleton is hoisted out of the hook-driven body into the
orchestrator so the body's data hooks/effects never run during app boot. It is
evaluated on the chat path only (after the money-request branch) to preserve the
prior behavior, where that skeleton lived inside the chat-only ReportActionsView,
and it owns the warm:false markOpenReportEnd telemetry for the branch it gates.

Add tests/ui/ReportActionsTest.tsx covering the orchestrator's branching
decisions and the app-load telemetry mark.
@LukasMod

LukasMod commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Regardless failing perf test, check PR description section about it. I compared sending messages with profiler and spans and didn't spot difference in performance (only noise)

image

@LukasMod LukasMod marked this pull request as ready for review June 17, 2026 11:17
@LukasMod LukasMod requested review from a team as code owners June 17, 2026 11:17
@melvin-bot melvin-bot Bot requested review from DylanDylann and heyjennahay and removed request for a team June 17, 2026 11:18
@melvin-bot

melvin-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team June 17, 2026 11:18

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5ec39cb02e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/inbox/report/ReportActionsList.tsx
@LukasMod

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e93921114a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/inbox/ReportActions.tsx
@LukasMod

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c4a6ea5e7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/inbox/report/ReportActionsSkeletonGuard.tsx Outdated
@LukasMod

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce3e927a32

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/inbox/ReportActions.tsx
@LukasMod

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: f97d91f366

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@LukasMod

LukasMod commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@DylanDylann I looked into splitting this and I don't think it's worth it, split would be like 5% + 95% of changes.
The orchestrator, the skeleton guard, the context, the model hook, the body rewire, both consumers getting repointed, and deleting ReportActionsView, is one interlocking change.

What is good, its mostly copy/pasting and unit tests. I updated PR description to make it a bit easier. Also with last commits number of changes reduced a lot so it should be a bit easier. Ready for review

@LukasMod LukasMod requested a review from DylanDylann June 25, 2026 13:04
@DylanDylann

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-06-26.at.17.57.43.mov
Android: mWeb Chrome
Screen.Recording.2026-06-26.at.17.48.55.mov
iOS: HybridApp
Screen.Recording.2026-06-26.at.17.50.08.mov
iOS: mWeb Safari
Screen.Recording.2026-06-26.at.17.47.53.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-26.at.17.45.21.mov

@DylanDylann DylanDylann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LukasMod. It's great job

@melvin-bot melvin-bot Bot requested a review from rlinoz June 26, 2026 11:01
@DylanDylann

Copy link
Copy Markdown
Contributor

@rlinoz Just a note: the failed Reassure Performance Tests are intentional

@LukasMod

Copy link
Copy Markdown
Contributor Author

new conflicts resolved

@rlinoz rlinoz merged commit 799f0de into Expensify:main Jun 29, 2026
33 of 34 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.25-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants