Update the personal expense rules table to the new style#93705
Merged
luacmartins merged 29 commits intoJun 29, 2026
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
JS00001
changed the title
melvin-bot
Bot
requested review from
flaviadefaria and
situchan
and removed request for
a team
Contributor
|
Nice! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42e0984a1c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…-personal-expense-rules-table
Contributor
Author
|
Yep I missed that comment, thanks! Updated @Krishna2323 |
luacmartins
previously approved these changes
Jun 26, 2026
This comment was marked as duplicate.
This comment was marked as duplicate.
Contributor
selections_are_cleared_when_filtered_by_search_input.mp4 |
…-personal-expense-rules-table
luacmartins
reviewed
Jun 29, 2026
luacmartins
left a comment
luacmartins
left a comment
Contributor
There was a problem hiding this comment.
@JS00001 jest and TS are failing
…-personal-expense-rules-table
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_hybrid.mp4Android: mWeb Chromeandroid_mWeb.mp4iOS: HybridAppios_hybrid.mp4iOS: mWeb Safariios_mWeb.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
Contributor
Author
|
Over to you @luacmartins |
|
@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
luacmartins
approved these changes
Jun 29, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Beamanator
added a commit
that referenced
this pull request
Jun 29, 2026
PR #93705 (merged to main 2026-06-29) landed PersonalExpenseRulesTableRow with a skeletonReasonAttributes prop that TableRow does not accept — TableRow's props derive from PressableWithFeedbackProps and add only {interactive, rowIndex, hovered, additionalContainerStyles, rowFooter}. This currently fails CI typecheck on every open PR. Open PRs #94896 and #94898 both propose the identical 1-line removal. Apply the same fix here so this PR's CI unblocks; when one of those merges to main and we next merge main back in, git resolves it as a no-op.
Contributor
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
60 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.25-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Updates the personal expense rules table to the new style
Fixed Issues
$ #86213
Tests
Test the functionality of the personal expense rules table to ensure all features still work
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Screen.Recording.2026-06-17.at.8.26.12.AM.mov