Fix: cursor position after flip (+/-) in new manual expense amount field by MelvinBot · Pull Request #94543 · Expensify/App

MelvinBot · 2026-06-25T05:44:09Z

Explanation of Change

On the new manual expense flow, tapping the flip (+/-) button in the amount field updated the value but never moved the text cursor (selection). On an empty field the selection stayed at {0, 0} — i.e. before the prepended - — so the next digit typed produced an invalid string like 5-. validateAmount rejects that string, setFormattedNumber returns early, and the entered number disappears. This reproduced both reported symptoms: "cursor appears before negative sign" and "number disappears after entering a number".

handleFlipPress in NumberWithSymbolForm.tsx now shifts the cursor by the length of the toggled sign (+1 when adding -, -1 clamped to 0 when removing it), keeping it in the same logical position relative to the digits. For the empty-field case the selection becomes {1, 1}, placing the cursor right after the - so subsequent typing stays valid. This mirrors how the imperative updateNumber handler already manages selection.

PR Expensify/App#94134 (removing the isNewManualExpenseFlowEnabled beta) didn't introduce this — it exposed a pre-existing flaw in the new manual flow by enabling it by default. That PR was reverted in Expensify/App#94312 to clear the deploy blocker; this PR fixes the underlying bug so the new flow is correct when re-enabled.

Fixed Issues

$ #94255
PROPOSAL: #94255 (comment)

Tests

Go to a workspace chat.
Open FAB > Create expense > Manual.
Tap the Amount field, then tap the flip (+/-) button.
Verify the cursor appears after the negative sign.
Enter a number and verify it is not discarded (e.g. -5).
Tap flip again to remove the sign and verify the cursor/value stay consistent.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Go to a workspace chat.
Open FAB > Create expense > Manual.
Tap the Amount field, then tap the flip (+/-) button.
Verify the cursor appears after the negative sign.
Enter a number and verify the number is not discarded.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

MelvinBot · 2026-06-25T05:48:06Z

🤖 The failing test (job 6) check is unrelated to this PR — it's a pre-existing/flaky failure, not something this PR introduced.

Failing test: NewChatPage › should keep a selected non-existing user visible in the top section after the search is cleared (tests/ui/NewChatPageTest.tsx:155).

Why it's unrelated:

This PR changes a single file, src/components/NumberWithSymbolForm.tsx (cursor position after the +/- flip in the amount field).
NumberWithSymbolForm is consumed only by amount/tax/IOU forms (MoneyRequestAmountForm, AmountForm, tax value pages, etc.). It is not imported by NewChatPage or anything in its render path, so this change cannot affect new-chat user-selection behavior.
The failure is a waitFor timeout on an async UI assertion — a classic flaky-test signature.

Recommendation: Re-run test (job 6). No code change is warranted here.

The checklist check is the PR author checklist (handled separately by a human), not a code failure.

thelullabyy · 2026-06-26T06:06:15Z

@MelvinBot Please merge main. After that replace all [ ] characters in PR description by [x]. Finally, open this PR for review

thelullabyy · 2026-06-27T02:10:53Z

@MelvinBot Please merge main. After that replace all [ ] characters in PR description by [x]. Finally, open this PR for review

thelullabyy · 2026-06-27T05:34:41Z

@MelvinBot Please merge main. After that replace all [ ] characters in PR description by [x]. Finally, open this PR for review

…orSelection Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

melvin-bot · 2026-06-27T05:41:43Z

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thelullabyy · 2026-06-27T05:42:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-27.at.01.44.18.mov

Screen.Recording.2026-06-29.at.01.32.42.mov

codecov · 2026-06-27T05:44:05Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/NumberWithSymbolForm.tsx	`68.78% <0.00%> (-1.11%)`	⬇️
... and 14 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31f05370d1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-27T05:45:35Z

+        setSelection((prevSelection) => ({
+            start: Math.max(prevSelection.start + offset, 0),
+            end: Math.max(prevSelection.end + offset, 0),
+        }));


Preserve manual selection updates on native

On native, the other programmatic update paths set willSelectionBeUpdatedManually (and numberRef.current) before changing selection because the controlled TextInput can emit onSelectionChange while the value update is being applied. This flip path changes the value and then sets the cursor, but leaves that guard unset, so in the new manual expense flow on iOS/Android the selection event can write the old {0,0} selection back after adding -, leaving the cursor before the sign and causing the next digit to be rejected/disappear. Apply the same manual-selection guard used by setFormattedNumber/setNewNumber around this update.

Useful? React with 👍 / 👎.

Valid catch — fixed in 6b8c9a5.

On native, shouldIgnoreSelectionWhenUpdatedManually is true, so handleSelectionChange only ignores the spurious onSelectionChange event when willSelectionBeUpdatedManually.current is set. handleFlipPress was changing the value and the selection but never setting that guard (unlike setNewNumber/setFormattedNumber), so the controlled TextInput could write the stale {0,0} selection back and undo the cursor shift.

The flip handler now sets willSelectionBeUpdatedManually.current = true and numberRef.current = newValue before updating the value/selection, matching the other update paths.

thelullabyy · 2026-06-27T05:46:18Z

@MelvinBot Please check this comment and fix if needed #94543 (comment)

thelullabyy · 2026-06-27T05:47:03Z

@MelvinBot You are using the wrong template for PR description. Let's update to use this https://raw.githubusercontent.com/Expensify/App/main/.github/PULL_REQUEST_TEMPLATE.md

Remember to replace all [ ] by [x]

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

melvin-bot · 2026-06-27T05:53:17Z

@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

LGTM

thelullabyy

LGTM

OSBotify · 2026-06-29T16:53:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-29T17:02:14Z

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-29T17:07:44Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94543.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-045e20d6d68-0f1cc02-33452aa9981e722cc91afcaefeadb33f5bc5dcaa/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-045e20d-0f1cc02-201ae6726a83e6a175740d7451beb673f003976a/index.html

Web 🕸️
https://94543.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-30T12:06:40Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-07-01T19:45:27Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Fix: move cursor after sign toggle in NumberWithSymbolForm flip button

d05faf3

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

MelvinBot assigned thelullabyy Jun 25, 2026

MelvinBot requested a review from a team June 25, 2026 05:44

MelvinBot mentioned this pull request Jun 25, 2026

[Due for payment 2026-07-08] [$250] Android - Cursor appears before negative sign, number disappears after entering number #94255

Open

7 tasks

Merge remote-tracking branch 'origin/main' into claude-flipButtonCurs…

31f0537

…orSelection Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

MelvinBot marked this pull request as ready for review June 27, 2026 05:41

MelvinBot requested a review from a team as a code owner June 27, 2026 05:41

melvin-bot Bot requested review from JmillsExpensify and thelullabyy and removed request for a team June 27, 2026 05:41

melvin-bot Bot removed the request for review from a team June 27, 2026 05:41

chatgpt-codex-connector Bot reviewed Jun 27, 2026

View reviewed changes

Guard manual selection update in flip handler for native

6b8c9a5

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

MelvinBot requested a review from a team as a code owner June 27, 2026 05:53

melvin-bot Bot requested review from puneetlath and removed request for a team June 27, 2026 05:53

JmillsExpensify approved these changes Jun 28, 2026

View reviewed changes

thelullabyy approved these changes Jun 29, 2026

View reviewed changes

puneetlath approved these changes Jun 29, 2026

View reviewed changes

puneetlath merged commit 045e20d into main Jun 29, 2026
38 of 41 checks passed

puneetlath deleted the claude-flipButtonCursorSelection branch June 29, 2026 16:48

OSBotify mentioned this pull request Jun 30, 2026

Deploy Checklist: New Expensify 2026-06-30 #94951

Closed

60 tasks

Uh oh!

Conversation

MelvinBot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Jun 25, 2026

Uh oh!

thelullabyy commented Jun 26, 2026

Uh oh!

thelullabyy commented Jun 27, 2026

Uh oh!

thelullabyy commented Jun 27, 2026

Uh oh!

melvin-bot Bot commented Jun 27, 2026

Uh oh!

thelullabyy commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented Jun 27, 2026

Uh oh!

thelullabyy commented Jun 27, 2026

Uh oh!

melvin-bot Bot commented Jun 27, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

thelullabyy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented Jun 25, 2026 •

edited

Loading

thelullabyy commented Jun 27, 2026 •

edited

Loading

codecov Bot commented Jun 27, 2026 •

edited by github-actions Bot

Loading