Skip to content

Fix: close expense creation RHP when clicking outside the open recipient list#94544

Merged
puneetlath merged 2 commits into
mainfrom
claude-fixParticipantPickerBackdropClose
Jun 29, 2026
Merged

Fix: close expense creation RHP when clicking outside the open recipient list#94544
puneetlath merged 2 commits into
mainfrom
claude-fixParticipantPickerBackdropClose

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

In the new manual expense flow (gated behind the NEW_MANUAL_EXPENSE_FLOW beta), the recipient list ("To" field) is rendered as a separate RIGHT_DOCKED Modal (ParticipantPicker) stacked on top of the expense-creation RHP. Clicking outside the panel only fired the picker's onClose, which just flips the picker's local visibility state — it never dismissed the underlying expense-creation RHP. So an outside click closed only the recipient list and left the expense RHP open, contradicting standard RHP behavior (clicking outside an RHP closes it).

This was the root cause of the deploy blocker originally surfaced when the beta was removed in #94134 (since reverted by #94312). The flow still has the bug behind the beta, so this PR fixes it directly.

Fix: The Modal component already exposes a backdrop handler (onBackdropPress) that is distinct from the back button. This PR:

  • Adds an optional onBackdropPress prop to ParticipantPicker and forwards it to its Modal. When omitted, the Modal falls back to onClose, so existing behavior is unchanged for any other usage.
  • In IOURequestStepConfirmation, wires onBackdropPress to Navigation.dismissModal() so an outside/backdrop click dismisses the entire expense-creation RHP.

The header back button (onBackButtonPressonClose) is intentionally left untouched, so pressing the back arrow still returns to the confirmation form, while clicking outside now closes the whole flow as expected.

Fixed Issues

$ #94246
PROPOSAL: #94246 (comment)

Tests

  1. Enable the NEW_MANUAL_EXPENSE_FLOW beta.
  2. Go to FAB > Create expense > Manual.
  3. Open the confirmation page and click the To field to open the recipient list.
  4. Click outside the panel (on the dimmed backdrop area).
  5. Verify the entire expense-creation RHP closes (not just the recipient list).
  6. Re-open the recipient list and instead press the back arrow in the header — verify it returns to the confirmation form (does not close the whole RHP).
  7. Verify that no errors appear in the JS console.

Offline tests

Same as tests (this is a navigation/UI-only change with no network dependency).

QA Steps

  1. Enable the NEW_MANUAL_EXPENSE_FLOW beta.
  2. Go to FAB > Create expense > Manual.
  3. Open the confirmation page and click the To field to open the recipient list.
  4. Click outside the panel.
  5. Verify the entire expense-creation RHP closes.
  6. Re-open the recipient list, press the header back arrow, and verify it returns to the confirmation form.
  7. Verify that no errors appear in the JS console.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

…list

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/ParticipantPicker.tsx 95.00% <ø> (ø)
...es/iou/request/step/IOURequestStepConfirmation.tsx 64.96% <0.00%> (-0.21%) ⬇️
... and 13 files with indirect coverage changes

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Fixed the failing PR Author Checklist / checklist check.

It wasn't failing on unchecked boxes — it was crashing with TypeError: Cannot read properties of undefined (reading 'split'). The authorChecklist action splits the PR body on ### PR Author Checklist### Screenshots/Videos, but the generated PR description was missing both sections, so the parser threw before it could evaluate anything (authorChecklist.ts:49-50).

Fix: Restored the standard ### PR Author Checklist and ### Screenshots/Videos sections in the PR description (boxes left unchecked).

The check now runs correctly and reports the normal "PR Author Checklist is not completely filled out" state — thelullabyy, please tick the checklist boxes and add the platform screenshots/videos before marking this ready for review.

All other checks (tests, typecheck, ESLint, Prettier, build, etc.) are passing; the *-perf-tests jobs are non-blocking.

@thelullabyy

Copy link
Copy Markdown
Contributor

@MelvinBot Please merge main. After that replace all [ ] characters in PR description by [x]. Finally, open this PR for review

…PickerBackdropClose

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>
@MelvinBot MelvinBot marked this pull request as ready for review June 26, 2026 06:20
@MelvinBot MelvinBot requested a review from a team as a code owner June 26, 2026 06:20
@melvin-bot melvin-bot Bot requested review from thelullabyy and removed request for a team June 26, 2026 06:20
@melvin-bot

melvin-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from trjExpensify and removed request for a team June 26, 2026 06:20
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done, @thelullabyy:

  1. Merged main into claude-fixParticipantPickerBackdropClose (merge commit c5d9ab0, no conflicts) and pushed.
  2. Replaced all [ ] with [x] in the PR description — 42 checkboxes updated, 0 unchecked remaining.
  3. Marked the PR ready for review (no longer a draft).

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep 'em coming! 👍

@thelullabyy

thelullabyy commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-29.at.01.49.34.mov

@melvin-bot melvin-bot Bot requested a review from puneetlath June 29, 2026 06:50
@puneetlath puneetlath merged commit 1a1cc4b into main Jun 29, 2026
40 of 42 checks passed
@puneetlath puneetlath deleted the claude-fixParticipantPickerBackdropClose branch June 29, 2026 19:20
@github-actions

Copy link
Copy Markdown
Contributor

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.25-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants