[NOQA] perf: extract MoneyRequestReportPreview carousel and message-animation hooks by OlimpiaZurek · Pull Request #94675 · Expensify/App

OlimpiaZurek · 2026-06-26T10:01:49Z

Explanation of Change

This is the first step in breaking up MoneyRequestReportPreviewContent — the ~800-line component that does several jobs at once (loading state, the preview-message animation, the header, the transaction carousel, and the hold menu).

This PR pulls the two biggest chunks of logic out into their own hooks and uses them directly in the component, so behavior is unchanged but the file gets noticeably smaller and easier to follow:

useReportPreviewCarousel — all the transaction-carousel state, refs, scrolling, and the prev/next arrow logic.
usePreviewMessageAnimation — the preview-message text and the opacity / checkmark / thumbs-up animations.

MoneyRequestReportPreviewContent goes from ~810 to ~570 lines and just calls these two hooks. Later PRs introduce the context/provider and split the remaining UI (header, carousel, total, hold menu) into their own components.

Fixed Issues

$ #94603
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-06-26T10:06:51Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`81.42% <100.00%> (+12.74%)`	⬆️
...RequestReportPreview/usePreviewMessageAnimation.ts	`76.19% <76.19%> (ø)`
...yRequestReportPreview/useReportPreviewCarousel.tsx	`75.86% <75.86%> (ø)`
... and 11 files with indirect coverage changes

melvin-bot · 2026-06-26T12:28:32Z

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OlimpiaZurek · 2026-06-26T12:29:49Z

@codex

chatgpt-codex-connector · 2026-06-26T12:33:50Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 9013f10338

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

trjExpensify · 2026-06-26T12:36:54Z

PR doesn’t need product input as a performance PR. Unassigning and unsubscribing myself.

abzokhattab · 2026-06-26T13:26:47Z

reviewing

abzokhattab · 2026-06-28T22:46:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-29.at.00.45.24.mov

abzokhattab

the changes looks good to me .. i flagged one issue that we need to confirm

other than that ... i validated the change using the following test steps:

Go to a chat that has an expense report preview card with 2 or more expenses
On the preview card, tap the left/right arrows to scroll through the expenses
Tap Submit on the preview card
Watch the animation play on the preview card after submitting ... verify that the animation works well.

mountiny · 2026-06-29T19:16:03Z

@OlimpiaZurek more conflicts

mountiny

Thanks

github-actions · 2026-06-30T08:56:12Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-30T09:01:52Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94675.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0adebf6-638513b-01f93836099a6865d236f53a64458d07a80f89eb/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0adebf6-638513b-5b9b6cd9fe130ebe674245d65345bf96a64871cd/index.html

Web 🕸️
https://94675.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

cristipaval · 2026-06-30T09:13:35Z

+    const previewMessageStyle = useAnimatedStyle(() => ({
+        opacity: previewMessageOpacity.get(),
+    }));
+    const checkMarkScale = useSharedValue(iouSettled ? 1 : 0);


NAB: checkMarkScale and thumbsUpScale are set here but I don't see anything reading them (no .get(), no animated style, no icon) — looks like dead code already on main. The docstring also says this hook plays "checkmark / thumbs-up animations", but nothing renders them. Since this is a cleanup refactor, should we just remove them (and fix the docstring), or were these animations supposed to be wired up?

Opened a follow-up issue to track this: #94944

OSBotify · 2026-06-30T12:06:58Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-07-01T19:45:45Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned OlimpiaZurek Jun 26, 2026

OlimpiaZurek force-pushed the perf/decompose-preview-1-context-hooks branch from 07c3ee0 to b3898e9 Compare June 26, 2026 10:11

perf: add MoneyRequestReportPreview context, provider and logic hooks

9013f10

OlimpiaZurek force-pushed the perf/decompose-preview-1-context-hooks branch from b3898e9 to 9013f10 Compare June 26, 2026 11:22

OlimpiaZurek marked this pull request as ready for review June 26, 2026 12:28

OlimpiaZurek requested review from a team as code owners June 26, 2026 12:28

melvin-bot Bot requested review from abzokhattab and trjExpensify and removed request for a team June 26, 2026 12:28

melvin-bot Bot removed the request for review from a team June 26, 2026 12:28

OlimpiaZurek changed the title ~~[NOQA] perf: add MoneyRequestReportPreview context, provider and logic hooks~~ [NOQA] perf: extract MoneyRequestReportPreview carousel and message-animation hooks Jun 26, 2026

trjExpensify removed their request for review June 26, 2026 12:36

OlimpiaZurek mentioned this pull request Jun 26, 2026

[Due for payment 2026-07-08] [$250] Perf/decompose money request report preview #94603

Open

LukasMod mentioned this pull request Jun 26, 2026

[Metrics] Improve ManualSendMessage #77176

Open

abzokhattab reviewed Jun 26, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/useReportPreviewCarousel.tsx

abzokhattab approved these changes Jun 28, 2026

View reviewed changes

melvin-bot Bot requested review from cristipaval and mountiny June 28, 2026 22:47

add comment explaining textBlue color

fb7a8b7

mountiny reviewed Jun 29, 2026

View reviewed changes

OlimpiaZurek added 2 commits June 29, 2026 14:57

address comments

7017714

Merge branch 'main' into perf/decompose-preview-1-context-hooks

a74b136

Merge branch 'main' into perf/decompose-preview-1-context-hooks

2d03a8f

mountiny approved these changes Jun 30, 2026

View reviewed changes

cristipaval approved these changes Jun 30, 2026

View reviewed changes

mountiny merged commit 0adebf6 into Expensify:main Jun 30, 2026
42 of 43 checks passed

This was referenced Jun 30, 2026

Investigate workflow job failing on main: test / test (job 7) #94941

Closed

Investigate workflow job failing on main: test / test (job 8) #94942

Closed

Investigate workflow job failing on main: test / test (job 2) #94943

Closed

cristipaval reviewed Jun 30, 2026

View reviewed changes

cristipaval mentioned this pull request Jun 30, 2026

[Perf] checkmark / thumbs-up animations are computed but never rendered #94944

Open

OSBotify mentioned this pull request Jun 30, 2026

Deploy Checklist: New Expensify 2026-06-30 #94951

Closed

60 tasks

Uh oh!

Conversation

OlimpiaZurek commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 26, 2026

Uh oh!

OlimpiaZurek commented Jun 26, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 26, 2026

Uh oh!

trjExpensify commented Jun 26, 2026

Uh oh!

abzokhattab commented Jun 26, 2026

Uh oh!

Uh oh!

abzokhattab commented Jun 28, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

abzokhattab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mountiny commented Jun 29, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

cristipaval Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

cristipaval Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

OlimpiaZurek commented Jun 26, 2026 •

edited

Loading

codecov Bot commented Jun 26, 2026 •

edited by github-actions Bot

Loading