feat: use X close icon for #admins room in side panel on desktop#94810
Merged
marcochavezf merged 1 commit intoJun 30, 2026
Conversation
Co-authored-by: Marco Chávez <marcochavezf@users.noreply.github.com>
iwiznia
approved these changes
Jun 29, 2026
Contributor
|
The change is trivial and worked locally, so I think we can merge this PR directly |
Contributor
|
🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
60 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.25-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
On desktop/wide screens, a report shown in the side panel (third pane) showed a back-arrow chevron (
<) in its header. Clicking it slides the panel closed to the right, which contradicts the<(back/left) affordance. TheXclose icon was previously added for Concierge chat only (#78870 / #78955), so the#adminsroom still showed the inconsistent chevron.The side-panel header (
src/pages/inbox/HeaderView.tsx) only ever renders the Concierge DM or the active workspace#adminsroom (the side-panelreportIDis sourced solely fromSidePanelContextProvider). In that layout the control opens/closes a panel rather than navigating a hierarchy, so anXis the correct affordance for both. This widens the close-button gate by dropping the Concierge-only condition:Small screens are unaffected (
!shouldUseNarrowLayoutis unchanged), and other RHPs use the separateHeaderWithBackButtoncomponent, so they keep the back arrow.Fixed Issues
$ #94809
PROPOSAL: #94809
Tests
Xis shown in the #admins room in the RHPOffline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari