Update the policy expensify card table to the new style#94860
Merged
Conversation
…o the new style""
Move the frozen card status below the row grid (matching the pre-table layout and Spend table violation pattern) so long admin names no longer wrap into adjacent columns.
melvin-bot
Bot
requested review from
JmillsExpensify,
Krishna2323 and
situchan
and removed request for
a team
|
@Krishna2323 @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23e1171a4c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const limitTypeLabel = translate(getTranslationKeyForLimitType(item.limitType)); | ||
| const formattedLimit = convertToShortDisplayString(item.limit, item.currency); | ||
| const formattedFrozenDate = item.frozenDate ? DateUtils.formatWithUTCTimeZone(item.frozenDate, CONST.DATE.MONTH_DAY_YEAR_ABBR_FORMAT) : ''; | ||
| const frozenByAdminPrefix = translate('cardPage.frozenByAdminPrefix', {date: formattedFrozenDate}); |
Contributor
There was a problem hiding this comment.
❌ PERF-2 (docs)
frozenByAdminPrefix calls translate('cardPage.frozenByAdminPrefix', ...) unconditionally for every rendered card row, but the value is only ever used inside the if (formattedFrozenDate) block below. For the common case (a non-frozen card, where formattedFrozenDate is empty) this performs a wasted translate lookup on every row.
Move the translate call inside the guard so it only runs when the card is actually frozen:
let frozenByText: string | undefined;
if (formattedFrozenDate) {
if (item.frozenByAccountID === session?.accountID) {
frozenByText = translate('cardPage.youFroze', {date: formattedFrozenDate});
} else {
const frozenByAdminPrefix = translate('cardPage.frozenByAdminPrefix', {date: formattedFrozenDate});
frozenByText = `${frozenByAdminPrefix}${item.frozenByDisplayName ?? translate('common.someone')}`;
}
}Reviewed at: 23e1171 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Contributor
|
How to freeze card? |
Contributor
Author
|
@situchan you can click on a card row > Freeze card Screen.Recording.2026-06-29.at.9.43.08.AM.mov |
Contributor
|
Gotcha. Only available on virtual card. Was testing on physical card |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movandroid.movAndroid: mWeb ChromeiOS: HybridAppios.movios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.movweb.mov |
Avoids unnecessary translate lookups on non-frozen card rows.
situchan
approved these changes
Jun 29, 2026
|
@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
luacmartins
requested review from
JS00001
and removed request for
tylerkaraszewski
JS00001
approved these changes
Jun 29, 2026
Contributor
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
60 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.25-0 🚀
|
7 tasks
|
Deploy Blocker #95003 was identified to be related to this PR. |
Contributor
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Migrate the policy Expensify Card list page to the shared
Tablecomponent.Render the frozen card status below the row (matching the Spend table violation pattern) so long admin names no longer wrap into adjacent columns.
Fixed Issues
$ #86212
$ #94750
Tests
Offline tests
N/A
QA Steps
Same as tests