-
Notifications
You must be signed in to change notification settings - Fork 146
Add GithubUtils and generateVersionComparisonURL #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GithubUtils and generateVersionComparisonURL #345
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@SombreroElGringo Looks like you've got some merge conflicts to resolve. |
3b13462 to
76a6456
Compare
|
Just a couple minor suggestions + the |
roryabraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@roryabraham will you please review this?
[Explanation of the change or anything fishy that is going on]
I added the class GithubUtils and its method generateVersionComparisonURL.
I installed the following missing packages 'semver' and '@actions/core'.
PS: Also for the tests I needed to use async/await else I got some timeout. Also I tried different workaround for example expect(Promise).resolves.toBe(url) but it was not working correctly. At least with async/await we are sure the tests are working correctly.
Fixed Issues
$ Expensify/App#1577
Tests
For repository with the following tags 2.2.2, 2.2.1, 2.1.0-1, 2.1.0, 2.0.0-1, 2.0.0, 1.2.2-2, 1.2.2-1, 1.2.2, 1.2.1, 1.2.0, 1.1.0, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0 and 0.0.1
MAJOR comparison
-- if we pass the tag 2.2.2 as param it should return https:///1.2.2...2.2.2
-- if we pass the tag 1.2.0 as param it should return https:///0.0.1...1.2.0
MINOR comparison
-- if we pass the tag 2.2.2 as param it should return https:///2.1.0...2.2.2
-- if we pass the tag 1.1.0 as param it should return https:///1.0.4...1.1.0
PATCH comparison
-- if we pass the tag 2.2.2 as param it should return https:///2.2.1...2.2.2
-- if we pass the tag 1.0.0 as param it should return https:///0.0.1...1.0.0
BUILD comparison
-- if we pass the tag 2.1.0-1 as param it should return https:///2.1.0...2.1.0-1
-- if we pass the tag 1.2.2-2 as param it should return https:///1.2.2...1.2.2-2
QA
If the
generateVersionComparisonURLreturn the good url following the parameters passed.