Skip to content

Conversation

@SombreroElGringo
Copy link
Contributor

@roryabraham will you please review this?

[Explanation of the change or anything fishy that is going on]

I added the class GithubUtils and its method generateVersionComparisonURL.
I installed the following missing packages 'semver' and '@actions/core'.

PS: Also for the tests I needed to use async/await else I got some timeout. Also I tried different workaround for example expect(Promise).resolves.toBe(url) but it was not working correctly. At least with async/await we are sure the tests are working correctly.

Fixed Issues

$ Expensify/App#1577

Tests

For repository with the following tags 2.2.2, 2.2.1, 2.1.0-1, 2.1.0, 2.0.0-1, 2.0.0, 1.2.2-2, 1.2.2-1, 1.2.2, 1.2.1, 1.2.0, 1.1.0, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0 and 0.0.1

MAJOR comparison
-- if we pass the tag 2.2.2 as param it should return https:///1.2.2...2.2.2
-- if we pass the tag 1.2.0 as param it should return https:///0.0.1...1.2.0

MINOR comparison
-- if we pass the tag 2.2.2 as param it should return https:///2.1.0...2.2.2
-- if we pass the tag 1.1.0 as param it should return https:///1.0.4...1.1.0

PATCH comparison
-- if we pass the tag 2.2.2 as param it should return https:///2.2.1...2.2.2
-- if we pass the tag 1.0.0 as param it should return https:///0.0.1...1.0.0

BUILD comparison
-- if we pass the tag 2.1.0-1 as param it should return https:///2.1.0...2.1.0-1
-- if we pass the tag 1.2.2-2 as param it should return https:///1.2.2...1.2.2-2

QA

If the generateVersionComparisonURL return the good url following the parameters passed.

@SombreroElGringo SombreroElGringo requested a review from a team as a code owner March 4, 2021 10:55
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@botify botify requested review from nickmurray47 and removed request for a team March 4, 2021 10:55
@SombreroElGringo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@SombreroElGringo SombreroElGringo changed the title Add GithubUtils and generateVersionComparaisonURL Add GithubUtils and generateVersionComparisonURL Mar 4, 2021
@roryabraham
Copy link
Contributor

recheck

@roryabraham
Copy link
Contributor

@SombreroElGringo Looks like you've got some merge conflicts to resolve.

@SombreroElGringo SombreroElGringo force-pushed the generate-version-comparaison-url branch from 3b13462 to 76a6456 Compare March 4, 2021 23:29
@roryabraham
Copy link
Contributor

Just a couple minor suggestions + the async/await -> promise changes. All minor stuff!

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roryabraham roryabraham merged commit b2898be into Expensify:master Mar 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2021
@SombreroElGringo SombreroElGringo deleted the generate-version-comparaison-url branch March 5, 2021 23:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants