Update versionComparisonURL to check build versions #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
|
@Jag96 No need to update expensify-common git hashes. I'm actually going to end up moving this code back over to Expensify.cash, because it just doesn't need to be in expensify-common. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
roryabraham
requested changes
Mar 9, 2021
Contributor
roryabraham
left a comment
roryabraham
left a comment
There was a problem hiding this comment.
Code looks good, but can we also fix the max-len lint warnings too?
Contributor
Author
|
@roryabraham updated! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roryabraham will you please review this?
cc @AndrewGable
This PR updates
generateVersionComparisonURLto check the build number in the version. I've also updated the tests to cover more version comparison cases. Once this is merged I'll update the expensify-common hashes in all the other repos.Fixed Issues
Related to https://github.com/Expensify/Expensify/issues/156562
Tests
Added automated tests
QA
N/A, we'll fully test this when we deploy