[No QA] Fix GitHub actions practices #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
commented
Oct 14, 2025
.github/workflows/cla.yml
Outdated
| regex: '\s*recheck\s*' | ||
|
|
||
| - name: CLA Assistant | ||
| if: ${{ steps.recheck.outputs.match != '' || steps.sign.outputs.match != '' || github.event_name == 'pull_request_target' }} |
Contributor
Author
There was a problem hiding this comment.
This condition was always evaluating to true because there were characters outside of the ${{ }}
roryabraham
commented
Oct 14, 2025
|
|
||
| # This workflow runs when code is pushed to `main` (i.e: when a pull request is merged) | ||
| on: | ||
| push: |
Contributor
Author
There was a problem hiding this comment.
I ignored differences in indentation across files because we aren't going to enforce a yaml style (yet). But 3-space indentation was too :eye_twitch: for me to handle
Contributor
Author
|
Shit, my local branch was out of date when I created this. Merged main, should be good now |
srikarparsi
previously approved these changes
Oct 15, 2025
tomekzaw
previously approved these changes
Oct 15, 2025
Collaborator
tomekzaw
left a comment
tomekzaw
left a comment
There was a problem hiding this comment.
LGTM, left one comment
roryabraham
dismissed stale reviews from tomekzaw and srikarparsi
via
57ca071
Co-authored-by: Tomasz Zawadzki <tomekzawadzki98@gmail.com>
tomekzaw
approved these changes
Oct 16, 2025
Contributor
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We are getting ready to enforce:
across the Expensify org. This PR prepares us for that to be turned on without disrupting development here.
Related Issues
https://github.com/Expensify/Expensify/issues/484931 (private repo)
Manual Tests
None.
Linked PRs
None.