Remove nested null values in objects (after revert)#380
Merged
tgolen merged 30 commits intoExpensify:mainfrom Oct 4, 2023
Merged
Remove nested null values in objects (after revert)#380tgolen merged 30 commits intoExpensify:mainfrom
tgolen merged 30 commits intoExpensify:mainfrom
Conversation
added 10 commits
September 29, 2023 11:47
…ader/remove-nested-nullish-object-keys"" This reverts commit f3a08f7.
chrispader
changed the title
melvin-bot
bot
requested review from
hayata-suenaga
and removed request for
a team
hayata-suenaga
requested review from
marcaaron,
neil-marcellini and
tgolen
and removed request for
hayata-suenaga
Contributor
|
Assigning the original reviewers or the reverted PR 🙇 |
tgolen
previously approved these changes
Oct 3, 2023
Co-authored-by: Tim Golen <tgolen@gmail.com>
Co-authored-by: Tim Golen <tgolen@gmail.com>
tgolen
approved these changes
Oct 3, 2023
neil-marcellini
approved these changes
Oct 3, 2023
Contributor
neil-marcellini
left a comment
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks good to me🤞
59 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marcaaron @blazejkustra @tgolen
Details
Original PR got reverted because of failing tests.
This PR fixes tests and improves consistency by also applying changes to
multiSetandmergeCollection.Failing tests in
Expensify/Appare fixed hereRelated Issues
GH_LINK
Automated Tests
Linked PRs