Omit null state and props to fix default props

[alex-mechler]

Part of https://github.com/Expensify/Expensify/issues/144333

React will only replace undefined props with defaultProps. We want to omit any state or props that are null when passing them to wrapped components to fix default props.

Test with Expensify/App#795

cc: @roryabraham @marcaaron

[roryabraham]

Looks good, but why remove null state instead of just null props?

[alex-mechler]

Looks good, but why remove null state instead of just null props?

We are passing the state of the withOnyx wrapper as props, not as state, to the wrapped components. If there is a null value in the withOnyx wrapper's state, it will be passed as a null prop, breaking defaultProps.

I actually ran into this breaking a component while testing (I think it was the typing indicator

[roryabraham]

Ohh gotcha. Thanks, that was super obvious looking at it again.

This PR looks good to me, but I'm going to hold off on merging it because there were some issues I ran into when testing Expensify/App#795. I'll post about them over there.

[roryabraham]

Okay, issues were resolved over there so I'm merging.