handle non-us language environments properly #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for this, and sorry for being slow to reply - have been on holiday abroad for two weeks and only just saw it. Will review tonight and merge as long as I can understand it! |
Owner
|
Are you sure this is actually necessary? Looking at https://github.com/git/git/blob/d67f9d5e8fd2c165304153a87fd96054d2b74981/builtin/clean.c#L31 it seems that this message is not localized, and I can't reproduce it being different by changing my system language to e.g. Turkish, Russian or German. |
Author
|
Using OS X and ArchLinux on multiple boxes the message was found to be localized. Using LANG=C has no negative side effects, it just ensures english language messages. |
ExplodingCabbage
added a commit
that referenced
this pull request
Apr 13, 2015
handle non-us language environments properly
Owner
|
Good enough for me. Thanks for the contribution and sorry it took me so long to get around to merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If used on a machine with non-us or C language settings the used git command fails to parse since it does not output the desired strings.
Added a LANG=C environment making the git command output predictable.