Send RF Mode Enum in place of RF Index in the Sync packet#2932
Merged
JyeSmith merged 9 commits intoExpressLRS:masterfrom Nov 8, 2024
Merged
Conversation
Collaborator
I think a "Band" selection above the packet rate would be really obvious. Would be hidden for SX chips. |
pkendall64
reviewed
Nov 4, 2024
SubG starts at 0, 2G4 starts at 20, and GemX at 100. Im still not happy with this and open to change, but for now it works with ETX and BF.
This needs a close review and more testing at release!!!
wvarty
approved these changes
Nov 5, 2024
pkendall64
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change in this PR is the Sync packet change to send RF Mode in place of the Index. This provides more flexibility with RF mode ordering in ExpressLRS_AirRateConfig and across hardware e.g. LR1121 to SX12XX. In addition, the remaining 900 modes have been added for full compatibility with the SX1276. Additional FSK modes have also been added to make the LR1121 as feature rich as the SX1280.
Things for discussion in this PR;
Things to discuss for future PRs;
And I know the config needs to be fixed so that there is an update pathway from previous version.