Merged
Conversation
JyeSmith
reviewed
Sep 26, 2024
Member
JyeSmith
left a comment
JyeSmith
left a comment
There was a problem hiding this comment.
Scrolling through the deletions all looks good.
Ill do some smoke testing before approval.
JyeSmith
approved these changes
Sep 29, 2024
wvarty
approved these changes
Sep 29, 2024
|
Why -DUNLOCK_HIGHER_POWER flag has been removed? |
Collaborator
Author
|
Because it's no longer required as all modules that support the highest power should also have a fan! |
frank26080115
pushed a commit
to frank26080115/ExpressLRS
that referenced
this pull request
Oct 19, 2024
* Remove STM32 files * Remove all the STM cruft from the python build code * Removing STM from code * Remove ghost & FM30 shenanigans
wimalopaan
pushed a commit
to wimalopaan/ExpressLRS
that referenced
this pull request
Oct 22, 2024
* Remove STM32 files * Remove all the STM cruft from the python build code * Removing STM from code * Remove ghost & FM30 shenanigans
|
Oh no! I just finished designing a board with an STM32L432! I guess I will have to make the next PCB revision use an ESP32? |
Collaborator
Author
We've been saying for quite some time that STM32 will no longer be supported from the next major version. |
|
I'm not blaming you at all! My mistake for not noticing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part one of whole series of PRs to expunge the code base of STM32 and to cleanup the ifdefs/defines.
I know this one is massive looking, but it's ~95% deleting files. Anyone reviewing might find it easier to look at the individual commits.