Add tlmConfirm to tlm_dl ota packet-structure#2991
Merged
Conversation
pkendall64
reviewed
Nov 9, 2024
wvarty
approved these changes
Nov 9, 2024
pkendall64
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added the SS confirmation bit to the downlink packet structure tlm_dl. The linkstats packet no longer needs to be spammed purely for the confirmation bit.
In addition the number of packet header types has been reduced. Now only 3 of the 4 uplink headers are in use, and only 2 are required for the downlink.
Marking as a draft for now as this PR will need some work after #2988 is merged.