fix: omit empty Attributes on UpdateItem UPDATED_NEW/UPDATED_OLD#121
Merged
pdf-amzn merged 1 commit intoMay 28, 2026
Merged
Conversation
yesyayen
force-pushed
the
fix/update-item-empty-attributes-on-delete
branch
from
f436fe1 to
7be239c
Compare
yesyayen
requested review from
LeeroyHannigan,
amrith,
c33howard,
jcshepherd and
pdf-amzn
as code owners
pdf-amzn
approved these changes
May 28, 2026
pdf-amzn
force-pushed
the
fix/update-item-empty-attributes-on-delete
branch
from
f14863f to
bcc7fd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
UpdateItemwithReturnValues=UPDATED_NEWorUPDATED_OLDnow matches DynamoDB when no targeted attribute is present in the chosen snapshot:REMOVE/ legacyDELETEon aMapattribute withUPDATED_NEW: response omitsAttributes(was{"Attributes": {}}).SETon a brand-new attribute withUPDATED_OLD: response omitsAttributes(was{"Attributes": {}}).Why
Closes #120
Testing done
Tested against real DynamoDB to confirm the expected behavior, then verified the fix against ExtendDB end-to-end. New tests:
TestUpdateItemcoveringREMOVE + UPDATED_NEW,SETof a brand-new attribute +UPDATED_OLD, and legacyAttributeUpdates DELETE+UPDATED_NEW.Checklist
cargo test --workspace)cargo fmt --check)cargo clippy --all-targets --workspace -- -D warnings)Breaking changes
None.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache License 2.0 and I agree to the Developer Certificate of Origin (DCO). See CONTRIBUTING.md for details.