fix: correctly urlencode parameters in the PostgreSQL connection string (URI)#92
Open
jcshepherd wants to merge 5 commits into
Open
fix: correctly urlencode parameters in the PostgreSQL connection string (URI)#92jcshepherd wants to merge 5 commits into
jcshepherd wants to merge 5 commits into
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PostgreSQL connection strings are URIs: components like host name, user name, password, etc., should be urlencoded. This indirectly addresses #52 (connecting to pg over unix socket.
Why
#52 - Enable extenddb init to correctly configure extenddb to connect to pg via unix socket.
Closes #52
Testing done
Unit tests, pytests over socket connection, manual test.
Automated testing is tricky because a new pg instance needs to be started when changing from unix to network socket connections.
Checklist
cargo test --workspace)cargo fmt --check)cargo clippy -- -W clippy::pedantic)By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache License 2.0 and I agree to the Developer Certificate of
Origin (DCO). See CONTRIBUTING.md for details.