added DateTimeFilter #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| $parts = explode(" - ", $search_param); | ||
|
|
||
| $start = new \DateTime($parts[0]); |
Member
There was a problem hiding this comment.
is it usefull to do something with possible exceptions?
Author
There was a problem hiding this comment.
I considered this, but rejected it because I'd rather see the error at the earliest stage than somehow catch it here and silence it or some such. This is an error that can only happen with bugs in development of the javascript part. When that's correct, it will not go wrong unless you manually manipulate stuff
| ], | ||
| "require": { | ||
| "php": "~5.3|~7.0", | ||
| "php": "~5.4|~7.0", |
Author
There was a problem hiding this comment.
because we use shorttag arrays (already in more code), and my editor said that's not possible in php 5.3 (only 5.4+), so I changed it rather than changing previous code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.