Feature: Setup cicd pipeline#18
Feature: Setup cicd pipeline#18ikovac wants to merge 82 commits intochore/migrate-to-typescript-with-bottlejs-and-mikro-ormfrom
Conversation
| const s3 = require('./s3'); | ||
|
|
||
| const siteDir = path.join(__dirname, '../dist/client'); | ||
| s3.copyDirToBucket(siteDir, s3.siteBucket); |
There was a problem hiding this comment.
Why publish dist through Pulumi instead of AWS orb through CI/CD pipeline?
There was a problem hiding this comment.
Because last week I spent all circleci free credits so I temporary set it this way 😅 but yes, the plan is to use aws orb to push dist folder to the S3 bucket
ikovac
added
👉 Need's code review
| version: 2.1 | ||
|
|
||
| defaults: &defaults | ||
| working_directory: ~/project/solution-tree |
|
@ikovac please resolve conflicts. |
…' of https://github.com/ExtensionEngine/app-starter into feature/ST-293_setup-cicd # Conflicts: # package-lock.json
|
@MiroDojkic resolved |
| build-client-prod: | ||
| <<: *build-client | ||
| build-server-dev: &build-server | ||
| working_directory: ~/project/app-starter |
There was a problem hiding this comment.
Should we keep working dir in a separate anchor than defaults so we can reuse it here as well?
| - kubernetes/install-kubectl | ||
| - pulumi/login | ||
| - run: | ||
| name: Stack init |
There was a problem hiding this comment.
Sorry for nitpicking, but please consider whether this is nicer for the eyes 😅
| name: Stack init | |
| name: Configure stack |
| <<: *deploy | ||
| deploy-prod: | ||
| <<: *deploy | ||
| push-to-s3-dev: &push-to-s3 |
There was a problem hiding this comment.
Does this name match the job intention better?
| push-to-s3-dev: &push-to-s3 | |
| deploy-client-dev: &deploy-client |
| <<: *push-to-s3 | ||
|
|
||
| workflows: | ||
| test-and-deploy: |
There was a problem hiding this comment.
Can we try to make workflows a bit easier to read through parametrization or something else?
There was a problem hiding this comment.
As far I saw, only jobs can be parametrized, and here we need to parametrize it with context and filters which are part of the workflow and not the job itself. Have I missed something?
| FROM node:14.18.1 as builder | ||
| WORKDIR /usr/src/app | ||
| COPY package*.json ./ | ||
| RUN npm install |
There was a problem hiding this comment.
Should we use npm ci instead to match the dependency versions in lock file?
| "rewrite-lockfile": "^1.0.0", | ||
| "rimraf": "^3.0.2", | ||
| "sass": "^1.43.2", | ||
| "sass": "~1.32.13", |
There was a problem hiding this comment.
Why do we need to lock ourselves to patch version?
There was a problem hiding this comment.
Because later versions display vuetify warnings about using / scss operator instead of math.div()
2 participants
This PR:
Infrastructure components: