Merged
Conversation
# Conflicts: # src/v2/components/database/index.ts
mandryllo
changed the title
droguljic
requested changes
Jan 19, 2026
Contributor
droguljic
left a comment
droguljic
left a comment
There was a problem hiding this comment.
Rename feat: to test: in PR name.
mandryllo
changed the title
bornast
reviewed
Jan 20, 2026
Member
bornast
left a comment
bornast
left a comment
There was a problem hiding this comment.
Looks good but i would suggest we add an integration test where we check if db is created like we did in default db tests.
bornast
approved these changes
Jan 21, 2026
droguljic
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the fourth one in order to resolve #70 and it will test custom configuration of our db component (setting various instance & storage arguments, setting custom password, kms key & parameter group, enabling monitoring and setting tags)