Skip to content

Reject zero cleanup report limits#499

Merged
chubes4 merged 1 commit into
mainfrom
fix/issue-493-limit-zero-semantics
Jun 2, 2026
Merged

Reject zero cleanup report limits#499
chubes4 merged 1 commit into
mainfrom
fix/issue-493-limit-zero-semantics

Conversation

@chubes4

@chubes4 chubes4 commented Jun 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Require positive --limit values for cleanup/report pagination surfaces instead of silently treating 0 as unbounded or 1.
  • Keep artifact cleanup's full scan available only through the explicit --exhaustive mode, and update CLI/ability help text to document that contract.
  • Add smoke coverage for cleanup artifacts, metadata reconciliation, active-no-signal reports, invalid negative limits, and budgeted/unbounded behavior.

Closes #493

Verification

  • php tests/smoke-worktree-cleanup-artifacts.php
  • php tests/smoke-worktree-cleanup-artifacts-bounded.php
  • php tests/smoke-worktree-metadata-reconcile.php
  • php tests/smoke-worktree-cleanup-cli.php
  • homeboy test --path /Users/chubes/Developer/data-machine-code@fix-issue-493-limit-zero-semantics --extension wordpress (passes, but host-smoke pattern did not match this repo's tests/smoke-*.php files)
  • homeboy lint --path /Users/chubes/Developer/data-machine-code@fix-issue-493-limit-zero-semantics --extension wordpress --changed-only

Notes

  • Full homeboy lint --path /Users/chubes/Developer/data-machine-code@fix-issue-493-limit-zero-semantics --extension wordpress still reports the existing repo-wide PHPStan baseline (173 findings); changed-only lint passes.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (gpt-5.5)
  • Used for: Implementation draft, tests, and verification; Chris remains responsible.

@homeboy-ci

homeboy-ci Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since 3d48737

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/26775054825

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since 3d48737

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/26775054825

Audit

audit — passed

  • audit — 48 finding(s)
  • Total: 48 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since 3d48737

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/26775054825
Tooling versions
  • Homeboy CLI: homeboy 0.216.2+fda89f5
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: c9f28f7b
  • Action: unknown@unknown

@chubes4 chubes4 merged commit f1b2a83 into main Jun 2, 2026
5 checks passed
@chubes4 chubes4 deleted the fix/issue-493-limit-zero-semantics branch June 2, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make cleanup and worktree report limit semantics consistent

1 participant