fix: align named argument class → class_name for PHP 8 compatibility#73
Merged
fix: align named argument class → class_name for PHP 8 compatibility#73
Conversation
The StepTypeRegistrationTrait parameter is $class_name, but the caller used class: which is a reserved word in PHP. This caused a fatal error on PHP 8.4 when data-machine was updated to the latest trait version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
StepTypeRegistrationTrait::registerStepType()parameter was renamed from$classto$class_namein data-machine commitfe240d7f, but this caller still usedclass:as a named argument — which is a reserved word in PHP 8.This caused a fatal error on the events site after the latest data-machine deploy:
One-character fix:
class:→class_name:.