fix: resolve lint/audit findings (#982, #981, #835, #865)#1077
Merged
Conversation
- #982: Fix Yoda condition in EmailAbilities (stripos check) - #981: Fix missing spaces before => in InsertContentAbility - #835: Fix check_permission() signature mismatch in Email API - #865: Add translators comments to i18n calls with placeholders Also filed homeboy false positives for: - homeboy#1134: namespace_mismatch on Global reserved word - homeboy#1135: missing_import on same-namespace references - homeboy#1136: unused_function_parameter on contract params
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 4 real lint/audit findings and documents 3 false positives filed against homeboy.
Real fixes
EmailAbilities.phpstripos() !== falseto Yoda:false !== stripos()InsertContentAbility.php=>in array pairsinc/Api/Email.phpWP_REST_Request $requestparam tocheck_permission()inc/Api/System/System.phptranslators:comments above__()calls with placeholdersFalse positives filed against homeboy
namespace_mismatchon PHP reserved wordGlobalin namespace segmentmissing_importflags same-namespace references and self-importsunused_function_parameterflags required REST/filter contract paramsFixes #982, Fixes #981, Fixes #835, Fixes #865