Skip to content

fix: resolve lint/audit findings (#982, #981, #835, #865)#1077

Merged
chubes4 merged 1 commit intomainfrom
fix/lint-audit-small-fixes
Apr 17, 2026
Merged

fix: resolve lint/audit findings (#982, #981, #835, #865)#1077
chubes4 merged 1 commit intomainfrom
fix/lint-audit-small-fixes

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented Apr 17, 2026

Summary

Fixes 4 real lint/audit findings and documents 3 false positives filed against homeboy.

Real fixes

Issue File Fix
#982 — yoda (1) EmailAbilities.php Flip stripos() !== false to Yoda: false !== stripos()
#981 — whitespace (2) InsertContentAbility.php Add missing spaces before => in array pairs
#835 — signature mismatch (1) inc/Api/Email.php Add WP_REST_Request $request param to check_permission()
#865 — i18n (3) inc/Api/System/System.php Add translators: comments above __() calls with placeholders

False positives filed against homeboy

Issue Root cause
homeboy#1134 namespace_mismatch on PHP reserved word Global in namespace segment
homeboy#1135 missing_import flags same-namespace references and self-imports
homeboy#1136 unused_function_parameter flags required REST/filter contract params

Fixes #982, Fixes #981, Fixes #835, Fixes #865

- #982: Fix Yoda condition in EmailAbilities (stripos check)
- #981: Fix missing spaces before => in InsertContentAbility
- #835: Fix check_permission() signature mismatch in Email API
- #865: Add translators comments to i18n calls with placeholders

Also filed homeboy false positives for:
- homeboy#1134: namespace_mismatch on Global reserved word
- homeboy#1135: missing_import on same-namespace references
- homeboy#1136: unused_function_parameter on contract params
@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci bot commented Apr 17, 2026

Homeboy Results — data-machine

Audit

⚡ Scope: changed files only

audit (changed files only)

  • Alignment score: 0.800
  • Outliers in current run: 44
  • Drift increased: no
  • Severity counts: info: 181, unknown: 44, warning: 429
  • Top actionable findings:
    1. inc/Abilities/AgentTokenAbilities.php — missing_import — Missing import: DataMachine\Abilities\PermissionHelper
    2. inc/Abilities/AbilityCategories.php — naming_mismatch — Helper-like name does not match convention suffix 'Abilities': AbilityCategories
    3. inc/Abilities/Analytics/PageSpeedAbilities.php — missing_method — Missing method: fetchStats
    4. inc/Api/Execute.php — missing_method — Missing method: check_permission
    5. inc/Api/StepTypes.php — missing_method — Missing method: check_permission
    6. inc/Api/Tools.php — missing_method — Missing method: check_permission
    7. inc/Api/Providers.php — missing_method — Missing method: check_permission
    8. inc/Api/Handlers.php — missing_method — Missing method: check_permission
    9. inc/Api/WebhookTrigger.php — missing_method — Missing method: check_permission
    10. inc/Core/Auth/AgentAuthMiddleware.php — missing_method — Missing method: register_routes
Audit findings (10 shown)
1. **inc/Abilities/AgentTokenAbilities.php** — missing_import — Missing import: DataMachine\Abilities\PermissionHelper
2. **inc/Abilities/AbilityCategories.php** — naming_mismatch — Helper-like name does not match convention suffix 'Abilities': AbilityCategories
3. **inc/Abilities/Analytics/PageSpeedAbilities.php** — missing_method — Missing method: fetchStats
4. **inc/Api/Execute.php** — missing_method — Missing method: check_permission
5. **inc/Api/StepTypes.php** — missing_method — Missing method: check_permission
6. **inc/Api/Tools.php** — missing_method — Missing method: check_permission
7. **inc/Api/Providers.php** — missing_method — Missing method: check_permission
8. **inc/Api/Handlers.php** — missing_method — Missing method: check_permission
9. **inc/Api/WebhookTrigger.php** — missing_method — Missing method: check_permission
10. **inc/Core/Auth/AgentAuthMiddleware.php** — missing_method — Missing method: register_routes
Tooling versions
  • Homeboy CLI: homeboy 0.88.7+cd399893
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: unknown
  • Action: Extra-Chill/homeboy-action@v2

Homeboy Action v1

@chubes4 chubes4 merged commit e9200e1 into main Apr 17, 2026
1 check passed
@chubes4 chubes4 deleted the fix/lint-audit-small-fixes branch April 17, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint: yoda in data-machine (1) lint: whitespace in data-machine (2) lint: i18n in data-machine (3) audit: signature mismatch in data-machine (1)

1 participant