fix: defer ability instantiation to init to resolve textdomain notice#150
Merged
chubes4 merged 1 commit intoExtra-Chill:mainfrom Feb 16, 2026
Merged
Conversation
Wraps all Abilities and ServiceProvider instantiation in an add_action('init')
callback so that __() calls in ability registration happen after translations
are loaded. Fixes the _load_textdomain_just_in_time notice on WP 6.7+.
Closes Extra-Chill#141
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps all Abilities and ServiceProvider instantiation in an
add_action('init')callback so that__()calls in ability registration happen after translations are loaded.Fixes the
_load_textdomain_just_in_timenotice that appears on every WP-CLI call (and likely admin pages) on WP 6.7+.The
require_oncelines (class file loading) remain atplugins_loaded— only thenewinstantiation calls are deferred toinit.Closes #141