Soft-skip AI steps that produce no actionable output#1790
Merged
Conversation
chubes4
added a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
job_statusengine override ofagent_skipped - ai_step_no_actionable_outputinstead of falling through to a generic empty-packet failure.failed - All N child jobs failed.datamachine_ai_step_soft_skip_on_empty_outputfilter (default true) so any pipeline that genuinely needs a hard-fail on empty AI output can opt out without re-pinning the old behavior in core.Why
For autonomous brain pipelines, the dominant outcome of any source search is: most fetched items don't deserve a wiki page. The pipeline's own system prompt says "skip irrelevant, too-thin, or transient chatter instead of writing filler." Today, every one of those skips renders as
failed - empty_data_packet_returned, trips parent batches intofailed, and discourages enabling additional source lanes.This change makes the model's intended skip path the operational skip path.
Fixes #1789.
Testing
php tests/ai-step-soft-skip-empty-output-smoke.php(new) — asserts the override completes the job asagent_skipped, persists the soft-skip reason, and does NOT emitdatamachine_fail_job. Also asserts the no-override path still fails withempty_data_packet_returned.php tests/ai-error-status-propagation-smoke.php— existing AI failure status propagation still passes.php tests/wp-ai-client-tool-schema-smoke.phpphp tests/wp-ai-client-request-timeout-smoke.phpphp -l inc/Core/Steps/AI/AIStep.phpAI assistance