Skip to content

Use tool runtime metadata in agent loop#1951

Merged
chubes4 merged 2 commits into
mainfrom
fix-agent-loop-tool-ux
May 11, 2026
Merged

Use tool runtime metadata in agent loop#1951
chubes4 merged 2 commits into
mainfrom
fix-agent-loop-tool-ux

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 11, 2026

Summary

  • Replaces Data Machine core's hardcoded extension tool-name lists with generic runtime metadata on tool definitions/results.
  • Uses duplicate_policy: repeatable to allow safe repeated inspection calls and completion_signal: progress to decide when missing completion assertions should nudge immediately.
  • Marks successful daily memory writes as progress and updates smoke coverage with generic tool names.

Testing

  • php -l inc/Engine/AI/ConversationManager.php
  • php -l inc/Engine/AI/conversation-loop.php
  • php -l inc/Engine/AI/Tools/BaseTool.php
  • php -l inc/Engine/AI/Tools/Global/AgentDailyMemory.php
  • php -l tests/agent-conversation-runtime-policy-smoke.php
  • php tests/agent-conversation-runtime-policy-smoke.php
  • git diff --check

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Drafted the generic runtime metadata contract, implementation, and focused smoke test updates; Chris directed the architecture away from hardcoded extension names.

@chubes4 chubes4 merged commit fc1d785 into main May 11, 2026
3 checks passed
@chubes4 chubes4 deleted the fix-agent-loop-tool-ux branch May 11, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant