Skip to content

fix: emit canonical pending action resolution hooks#2227

Merged
chubes4 merged 2 commits into
mainfrom
fix/pending-action-resolved-contract
May 24, 2026
Merged

fix: emit canonical pending action resolution hooks#2227
chubes4 merged 2 commits into
mainfrom
fix/pending-action-resolved-contract

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 24, 2026

Summary

  • Replaces the legacy datamachine_pending_action_resolved hook payload with the canonical Agents API action, decision, and resolver contract.
  • Updates the only in-repo runtime consumer to read Data Machine job context from metadata.datamachine.context.
  • Updates pending-action docs and smoke coverage to pin the resolved hook signature and removal of legacy_payload().

Verification

  • php tests/pending-actions-agents-api-contract-smoke.php
  • php -l inc/Engine/AI/Actions/WordPressActionDispatchObserver.php && php -l inc/Engine/Actions/DataMachineActions.php && php -l tests/pending-actions-agents-api-contract-smoke.php
  • vendor/bin/phpcs inc/Engine/AI/Actions/WordPressActionDispatchObserver.php inc/Engine/Actions/DataMachineActions.php tests/pending-actions-agents-api-contract-smoke.php
  • homeboy test --path /Users/chubes/Developer/data-machine@fix-pending-action-resolved-contract --extension wordpress

Verification gaps

  • homeboy lint --path /Users/chubes/Developer/data-machine@fix-pending-action-resolved-contract --extension wordpress reports existing repository-wide frontend lint findings outside this change.

Fixes #2222.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Auditing pending-action resolved hook consumers, implementing the canonical hook contract, updating smoke coverage and docs, and running verification.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented May 24, 2026

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since cd06f9c

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26350431242

Test

test — passed

  • 605 passed
  • 3 skipped

ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Save test baseline: homeboy test data-machine --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine --changed-since cd06f9c

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26350431242

Audit

audit — passed

  • requested_detectors — 10 finding(s)
  • intra-method-duplication — 7 finding(s)
  • dead_code — 3 finding(s)
  • Directives — 1 finding(s)
  • Retention — 1 finding(s)
  • Total: 22 finding(s)

Deep dive: homeboy audit data-machine --changed-since cd06f9c

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26350431242
Tooling versions
  • Homeboy CLI: homeboy 0.197.3+3c982b18
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: dd23ee80
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 4ca4232 into main May 24, 2026
5 checks passed
@chubes4 chubes4 deleted the fix/pending-action-resolved-contract branch May 24, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace legacy pending-action resolved hook payload with canonical Agents API action

1 participant