Skip to content

Fix handler-required AI transition routing#2231

Merged
chubes4 merged 1 commit into
mainfrom
fix/issue-2226-explicit-ai-fanout
May 24, 2026
Merged

Fix handler-required AI transition routing#2231
chubes4 merged 1 commit into
mainfrom
fix/issue-2226-explicit-ai-fanout

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 24, 2026

Summary

  • Resolve transition routing before the inline 0-1 packet shortcut so handler-required AI transitions use the explicit policy for every packet count.
  • Fail AI -> publish/upsert transitions clearly when required ai_handler_complete packets are absent instead of scheduling unrelated packets into the next handler step.
  • Add regression coverage for single-packet and empty-packet handler-required transitions while preserving non-handler fan-out behavior.

Fixes #2226.

Verification

  • php -l inc/Abilities/Engine/ExecuteStepAbility.php
  • php -l tests/Unit/Abilities/Engine/ExecuteStepFanOutFilterTest.php
  • php -l tests/transition-fanout-policy-smoke.php
  • php tests/transition-fanout-policy-smoke.php
  • vendor/bin/phpcs inc/Abilities/Engine/ExecuteStepAbility.php tests/Unit/Abilities/Engine/ExecuteStepFanOutFilterTest.php tests/transition-fanout-policy-smoke.php
  • git diff --check
  • homeboy test --path /Users/chubes/Developer/data-machine@fix-issue-2226-explicit-ai-fanout --extension wordpress --force-hot

Verification gaps

  • homeboy lint --path /Users/chubes/Developer/data-machine@fix-issue-2226-explicit-ai-fanout --extension wordpress --force-hot still reports existing frontend lint findings outside this PHP routing change.
  • Initial homeboy test --extension wordpress-plugin was invalid because this repo declares the wordpress extension.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Implemented the focused routing fix, added regression coverage, and ran verification; Chris remains responsible for review and merge.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented May 24, 2026

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since cd06f9c

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26350280678

Test

test — passed

  • 13 passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Save test baseline: homeboy test data-machine --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine --changed-since cd06f9c

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26350280678

Audit

audit — passed

  • requested_detectors — 13 finding(s)
  • intra-method-duplication — 10 finding(s)
  • dead_code — 5 finding(s)
  • Directives — 1 finding(s)
  • Retention — 1 finding(s)
  • Total: 30 finding(s)

Deep dive: homeboy audit data-machine --changed-since cd06f9c

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26350280678
Tooling versions
  • Homeboy CLI: homeboy 0.197.3+b742d51d
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: dd23ee80
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 65021e5 into main May 24, 2026
5 checks passed
@chubes4 chubes4 deleted the fix/issue-2226-explicit-ai-fanout branch May 24, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make AI fan-out packet routing explicit before 1.0

1 participant