fix: revert out-of-scope Homeboy autofix from #973#975
Merged
Conversation
This reverts commit 55340db.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts
55340db987d541d853d4cbd10d5b53aa81be4445(chore(ci): homeboy autofix — refactor (115 files)) which was added to PR #973 by Homeboy CI.Why
PR #973's intended human change touched only 2 files:
inc/Engine/AI/Tools/ToolPolicyResolver.phptests/Unit/AI/Tools/ToolPolicyResolverTest.phpHomeboy then added a repo-wide autofix commit touching 115 files. That exceeds the intended PR-scoped autofix behavior (changed files + tightly related call sites).
Impact assessment
This does not revert the intended feature from #973 (per-tool chat tool resolution). It only removes the broad bot-generated refactor churn.
While much of the autofix commit was mechanical, it also included semantic/code-shape changes in unrelated files (for example repeated duplicate DB query patterns in
PostIdentityIndex.php), so it should not remain piggybacked inside a small feature PR.Validation
main