fix(ci): auto-refactor should run even when quality gates fail#930
Merged
fix(ci): auto-refactor should run even when quality gates fail#930
Conversation
Auto-refactor was gated on gate-test succeeding, but tests depend on lint which depends on audit. Since audit always fails (868 findings), the entire chain was skipped — auto-refactor never ran. Fix: gate auto-refactor only on the build succeeding (needs the binary) and check saying there's something to release. List all quality gate jobs in needs so it waits for them to complete, but use always() so it runs regardless of their results. The whole point of auto-refactor is to fix what the quality gates found.
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Auto-refactor has never run in the release pipeline because it was gated on
gate-test.result == 'success':The whole point of auto-refactor is to fix what the quality gates found. Gating it on their success means it can never run when there's work to do.
Fix
needs) but doesn't require they passpreparedependency — auto-refactor shouldn't wait for the release stepalways()so skipped/failed upstream jobs don't block itImpact
After this merge, the next scheduled release run will actually run auto-refactor for the first time, attempting to fix audit findings automatically.