Update MerlinAU.sh Updated the Changelog Review Logic#107
Update MerlinAU.sh Updated the Changelog Review Logic#107Martinski4GitHub merged 2 commits intodevfrom
Conversation
Taking a look now... |
My only concern with parsing this way now that I review the PR is that what if we happen to just throw a note in that says "as of 388.6, blah blah blah" well that as of 388.6 for example would be considered end of the log. |
|
But the bypass is absolutely required. |
When searching for the version string, it must be at the start of the line. Try a regex that looks like this:
This way it's highly unlikely to be anything other than the beginning of the section for that specific version. |
Agreed. |
MerlinAU.sh
Outdated
|
|
||
| #For AMTM versioning: | ||
| readonly SCRIPT_VERSION=1.0.0 | ||
| readonly SCRIPT_VERSION=1.0.2 |
There was a problem hiding this comment.
Why version "1.0.2"?
|
Done! 👍 |
|
I like the addition of the start of line check and the regex of the pattern following. (Date) |
2 participants
Changelog review now parses the following versions as such:
3004.386.8.beta3 --> 386.8 end point for change log review
3004.386.8.4 --> 386.8 end point for change log review
Or
388.5.0 --> 388.5 end point for change log review
3004.388.5 --> 388.5 end point for change log review
Also added a changelog review bypass; incase the log contents are empty, or the "current" version of the firmware is not identified as a stopping point for the changelog file scrub.