Skip to content

Update MerlinAutoUpdate.sh#12

Merged
ExtremeFiretop merged 1 commit intoExtremeFiretop:mainfrom
Martinski4GitHub:main
Oct 13, 2023
Merged

Update MerlinAutoUpdate.sh#12
ExtremeFiretop merged 1 commit intoExtremeFiretop:mainfrom
Martinski4GitHub:main

Conversation

@Martinski4GitHub
Copy link
Collaborator

Code modifications/additions to use the router's built-in "F/W Update Check" & NVRAM variables to get the latest release update version to set or reset the delayed days for actual updates. Also added a menu item to enable/disable the built-in "F/W Update Check" so that users can control the Auto-Update feature from the same place as the router. Other miscellaneous code improvements.

Code modifications/additions to use the built-in "F/W Update Check" & NVRAM variables to get latest release update version to set or reset the delayed days for actual update. Also added menu item to enable/disable the built-in "F/W Update Check" so that users can control the Auto-Update feature from the same place as the router. Other miscellaneous code improvements.
@ExtremeFiretop ExtremeFiretop merged commit 9b06c6d into ExtremeFiretop:main Oct 13, 2023
@ExtremeFiretop
Copy link
Owner

So much good work here, I just quickly removed the duplicate "Current firmware version '388.4.0' is up to date." message, otherwise I haven't found any issues with your suggested changes on my router :D

Many thanks again Martin!

@Martinski4GitHub
Copy link
Collaborator Author

... I just quickly removed the duplicate "Current firmware version '388.4.0' is up to date." message, ...

Good catch! Honestly, more testing is actually needed under various conditions and on different router models to validate the code. I can only do some limited testing on my own, but I do some unit testing as needed and as my free time permits.

@ExtremeFiretop
Copy link
Owner

... I just quickly removed the duplicate "Current firmware version '388.4.0' is up to date." message, ...

Good catch! Honestly, more testing is actually needed under various conditions and on different router models to validate the code. I can only do some limited testing on my own, but I do some unit testing as needed and as my free time permits.

Same with me, I can't always actually test the flash, lots of the time I comment it out, but when time permits I test it all the way through on my unit as well. :D

Thanks so much for your interest in making this as solid as possible, I think it's already come a long way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants