Update MerlinAU.sh#123
Conversation
1) Ported code over to support the option to have a secondary email address to receive email notifications (using "CC" parameter). Still working on the menu selection to allow the user to define the email address & email name/alias. 2) Modify the "email notification" code to address the issue reported when GMX email server would insert "garbage lines" in the emails being sent. 3) Minor code improvements.
|
My man, you've been busy! |
|
Just FYI, I'm still working on the menu option for the secondary email address, but I wanted to get the latest changes that address the GMX email server problem and more code improvements in the "email notification" code. Hopefully, you'll get a chance to check & verify these changes by the time I get the menu selection completed. I've verified the fix using iCloud, GMail, Outlook & GMX accounts. |
Yes I see that now, no worries I'll review the email code improvements instead 🗡️ |
|
While testing this I realized the Backupmon versioning format has changed and now broke the version check:
|
|
Review done. Testing done. That can be resolved in it's own PR. Feel free to merge at anytime your ready. |
That was fast!! Thanks for the review & validation.
Yeah, I saw the post where Viktor issued the latest version of BackupMon and mentioned changing the versioning scheme. At the time, I just assumed he had already told you about it. I should've given you a heads-up at least when I read the post. Sorry about that.
I think I'll merge this PR now since it's already reviewed & approved. That way, the next set of changes can be reviewed separately. |
No worries at all, I made a joke to viktor in the forums just this morning about how he should of told me </3
Sounds good to me!! I'm happy with that trust me lol! |
With Hotmail & Gmail, plus the others I have tested with (one account is from my wife actually), we covered pretty much most of the well-known players WRT email (at least here in North America, I don't know what they use in South America, Europe, Asia, Africa, etc.) I just finished testing the CC feature and it's working pretty well so far. I must admit, I do like having the ability to send email notifications to a 2nd email account. As you said, this feature will be very useful when managing someone else's router so that one can send email notifications to both parties. |
I've already set it up for that small side gig I mentioned had an AX88U Pro with our script lol. I couldn't wait for production I wanted it on that router right away lol. |
2 participants
Ported code over to support the option to have a secondary email address to receive email notifications via the "CC" parameter. Still working on the menu selection to allow the user to define the email address & email name/alias.
Modify the "email notification" code to address the issue reported when the GMX email server would insert "garbage lines" in the emails being sent. See the following link for a post in the SNB Forum that has more details of the problem.
https://www.snbforums.com/threads/backupmon-v1-5-3-feb-14-2024-backup-restore-your-router-jffs-nvram-external-usb-drive-now-available-in-amtm.86645/page-43#post-892220