Skip to content

Update MerlinAU.sh#126

Merged
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev
Feb 18, 2024
Merged

Update MerlinAU.sh#126
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev

Conversation

@Martinski4GitHub
Copy link
Collaborator

Minor rewording & increased the size of the heading & font used for the body of the email (to help those of us with "old" eyes trying to read an email alert at 3:00 in the morning :>).

Minor rewording & increased the size of the heading & font used for the body of the email.
@Martinski4GitHub
Copy link
Collaborator Author

@ExtremeFiretop,
I'm going to go to sleep early today, so tomorrow I'll work on the new menu item to select the email format type. As mentioned, this is not critical so it's up to you if you want to wait, or if you rather issue a release of what we have so far, especially with the BackupMon versioning scheme fix.

@ExtremeFiretop ExtremeFiretop merged commit 08ca124 into ExtremeFiretop:dev Feb 18, 2024
@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Feb 18, 2024

Minor rewording & increased the size of the heading & font used for the body of the email (to help those of us with "old" eyes trying to read an email alert at 3:00 in the morning :>).

Literally just happened to me and I don't have old eyes lol!

I kept my script in debug mode (by accident) and went to bed, it's scheduled for Sundays at 4AM. So tonight.
It's now early in the morning and my phone went off ding ding ding.

Wake up, check it, and the router backed up and flashed itself successfully overnight from 388.6 to 388.6 LOL.
Oh well, checked the logs and everything still clean as a can be, (and that's with all my scripts running too!)
MerlinAU + Router Date Keeper + Entware + BACKUPMON + Connmon + Diversion + SpdMerlin

I made sure to return it to the production version.
But me reading the emails at 4AM was a blurry mess to say the least LOL!

@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Feb 18, 2024

@ExtremeFiretop, I'm going to go to sleep early today, so tomorrow I'll work on the new menu item to select the email format type. As mentioned, this is not critical so it's up to you if you want to wait, or if you rather issue a release of what we have so far, especially with the BackupMon versioning scheme fix.

No worries @Martinski4GitHub enjoy and rest well buddy. Chat more when you wake up :)
We still have time, I realize the firmware release RMerlin is working on is a security fix, so it may be pumped out quickly.

But I think we still have time, I'll give it until end of the weekend. (My Time) so end of Sunday, else I'll release as is. If you think you can complete it before then great! Otherwise no biggie.
I think people just haven't realized backupmon is broken yet, I rather have the fix out before people do lol!

@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Feb 18, 2024

@Martinski4GitHub

FYI: I touched up backupmon messaging for the logs in commit: 685cd72

Only reason was to cleanup the messages in the logs as found below:

2024-02-18 04:00:33 \nBackup Started (by BACKUPMON)
2024-02-18 04:02:05 Backup Finished\n
2024-02-18 04:02:05 Backup Completed Successfully\n

I also noticed I forgot to up the minimum version in the error message from 1.44 to 1.5.3 which was updated in that commit.
Just small things, no need for all the documentation of a PR. But wanted you aware none the less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants