Conversation
Added a new menu item in "Advanced Options" to give users the choice to select the email format type ("HTML" or "Plain Text"). Default type is HTML which should work with the well-known email servers. If any problems are observed with "garbage lines" getting inserted in the email contents, users can try selecting the "Plain Text" format and test again.
|
I woke up this morning and decided to implement the new menu item first thing today and get it out so you have more time to review, test & verify the functionality. FYI, today I'll be running some errands (the usual: grocery shopping with the wife, getting the cars cleaned, checking tires, fluid levels, etc.). So I'll be around but rather busy until about late in the afternoon, so I'll check back again at that time. |
|
Reviewing now! |
| ##-------------------------------------## | ||
| ## Added by Martinski W. [2024-Feb-18] ## | ||
| ##-------------------------------------## | ||
| _SetEMailFormatType_() |
There was a problem hiding this comment.
New Features! WHOOHOO! <3
| if ! grep -q "^FW_Allow_Beta_Production_Up" "$SETTINGSFILE" | ||
| then | ||
| sed -i "5 i FW_Allow_Beta_Production_Up ENABLED" "$SETTINGSFILE" | ||
| sed -i "11 i FW_Allow_Beta_Production_Up ENABLED" "$SETTINGSFILE" |
There was a problem hiding this comment.
Funny I never noticed this mistake until now. Thanks for fixing along the way! Lol.
|
Review went well. I understand all the changes, looks good so far. Testing now. |
| doReturnToMenu=false | ||
| while true | ||
| do | ||
| printf "\n${SEPstr}" |
There was a problem hiding this comment.
Btw you did good with the layout of this menu, well done.
Kinda makes me want to steal it for the ROG option instead of just having a yes or no lol!
|
Testing went well, merged! Approved! |
2 participants
Added a new menu item in "Advanced Options" to give users the choice to select the email format type ("HTML" or "Plain Text"). The default type is HTML which should work with the well-known email servers. If any problems are observed with "garbage lines" being inserted in the email contents, users can now try selecting the "Plain Text" format and test again.