Skip to content

Update MerlinAU.sh Quick Patch for ROG Menu#128

Merged
Martinski4GitHub merged 1 commit intodevfrom
ExtremeFiretop-ROG-Menu-Patch
Feb 19, 2024
Merged

Update MerlinAU.sh Quick Patch for ROG Menu#128
Martinski4GitHub merged 1 commit intodevfrom
ExtremeFiretop-ROG-Menu-Patch

Conversation

@ExtremeFiretop
Copy link
Owner

Update MerlinAU.sh

Quick Patch to Follow your fancy new menu standard on the ROG selection screen.
Tested and all seems to work well :)

@ExtremeFiretop ExtremeFiretop added the enhancement New feature or request label Feb 18, 2024
@ExtremeFiretop ExtremeFiretop changed the title Update MerlinAU.sh Quick Patch to Follow your Fancy Menu Standard Update MerlinAU.sh Quick Patch for ROG Menu Feb 18, 2024
@ExtremeFiretop
Copy link
Owner Author

If your happy with this, I guess we go to production next?
Let me know your final thoughts, if there's nothing else then lets go for it!

Copy link
Collaborator

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. The menus look more consistent WRT "look & feel."

@Martinski4GitHub
Copy link
Collaborator

Ready for production.

@Martinski4GitHub Martinski4GitHub merged commit 1600cb2 into dev Feb 19, 2024
@ExtremeFiretop ExtremeFiretop deleted the ExtremeFiretop-ROG-Menu-Patch branch February 19, 2024 00:14
@ExtremeFiretop
Copy link
Owner Author

Ready for production.

Gonna touch up the readme and version.text file and then make the post then!

Lots of good improvements in this round I say. High five buddy 🙏

Back to taking a break for a bit I think unless someone points something out we both missed.

@ExtremeFiretop
Copy link
Owner Author

Looks nice. The menus look more consistent WRT "look & feel."

Agreed, as soon as I saw what you did I felt the need to apply it to the ROG menu and it makes the ROG build stuff feel more integrated and less of a bolt on attachment lol!

@Martinski4GitHub
Copy link
Collaborator

@ExtremeFiretop,

Yeah, the script is looking much more polished and refined as the code matures and we make this kind of improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants