Merged
Conversation
Fixed bug causing the ZIP file to be deleted even when located on a USB-attached drive where Entware is installed & some code improvements in "Get_Custom_Setting()" function. Also modified "_DoCleanUp_" function to try to keep the ZIP file from being deleted under some conditions. Minor cleanup.
ExtremeFiretop
approved these changes
Dec 7, 2023
ExtremeFiretop
added
bug
Owner
|
This looks solid to me. I think this is pretty much ready for master honestly. |
Collaborator
Author
Yep, it's looking very good, more polished & production-ready for a "Main" branch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug causing the ZIP file to be deleted even when located on a USB-attached drive where Entware is installed & some code improvements in "Get_Custom_Setting()" function. Also modified "DoCleanUp" function to try to keep the ZIP file from being deleted under some conditions. Minor cleanup.