Skip to content

Updated MerlinAU.sh#49

Merged
ExtremeFiretop merged 4 commits intoExtremeFiretop:devfrom
Martinski4GitHub:dev
Dec 23, 2023
Merged

Updated MerlinAU.sh#49
ExtremeFiretop merged 4 commits intoExtremeFiretop:devfrom
Martinski4GitHub:dev

Conversation

@Martinski4GitHub
Copy link
Collaborator

Made a couple of changes regarding when to check that the LOG directory actually exists.

Just a couple of changes to double-check that the LOG directory actually exists.
Version increment.
Version increment.
@ExtremeFiretop
Copy link
Owner

Looks good to me!

Set the wait times for the "curl" command to return and then for the reboot (if necessary) to 3 minutes each.
@Martinski4GitHub
Copy link
Collaborator Author

Martinski4GitHub commented Dec 23, 2023

Looks good to me!

Just submitted changes to the wait times as discussed (3min + 3min).

@ExtremeFiretop ExtremeFiretop merged commit 321a14e into ExtremeFiretop:dev Dec 23, 2023
@ExtremeFiretop
Copy link
Owner

Merged!

@Martinski4GitHub
Copy link
Collaborator Author

Martinski4GitHub commented Dec 23, 2023

Merged!

It was very good timing that all these issues were caught before the Main version release had more exposure as it was. All these recent changes make the solution much more robust, IMO.

Happy Holidays, buddy!!!
(Hopefully, no more "surprises" until next year - not that I don't enjoy this kind of collaborative efforts)

@ExtremeFiretop
Copy link
Owner

Merged!

It was very good timing that all these issues were caught before the Main version release had more exposure as it was. All these recent changes make the solution much more robust, IMO.

Happy Holidays, buddy!!! (Hopefully, no more "surprises" until next year - not that I don't enjoy this kind of collaborative efforts)

I'll promote to production once I test it fully in the morning! Happy holidays buddy, job well done as always. This makes me verrrryyy happy hahaha

@Martinski4GitHub
Copy link
Collaborator Author

Merged!

It was very good timing that all these issues were caught before the Main version release had more exposure as it was. All these recent changes make the solution much more robust, IMO.
Happy Holidays, buddy!!! (Hopefully, no more "surprises" until next year - not that I don't enjoy this kind of collaborative efforts)

I'll promote to production once I test it fully in the morning!

Absolutely. The "Trust But Verify" philosophy is a sign of an experienced developer.

Happy holidays buddy, job well done as always.

Right back at you!! Here's a "¡Salud!" to you and your family.

This makes me verrrryyy happy hahaha

You and me both!!

@ExtremeFiretop
Copy link
Owner

Just wanted to mention that this has been successfully tested. I would of merged it into production but I figured let's talk out the LED situation of your latest PR first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants