Conversation
Just a couple of changes to double-check that the LOG directory actually exists.
Version increment.
Version increment.
|
Looks good to me! |
Set the wait times for the "curl" command to return and then for the reboot (if necessary) to 3 minutes each.
Just submitted changes to the wait times as discussed (3min + 3min). |
|
Merged! |
It was very good timing that all these issues were caught before the Main version release had more exposure as it was. All these recent changes make the solution much more robust, IMO. Happy Holidays, buddy!!! |
I'll promote to production once I test it fully in the morning! Happy holidays buddy, job well done as always. This makes me verrrryyy happy hahaha |
Absolutely. The "Trust But Verify" philosophy is a sign of an experienced developer.
Right back at you!! Here's a "¡Salud!" to you and your family.
You and me both!! |
|
Just wanted to mention that this has been successfully tested. I would of merged it into production but I figured let's talk out the LED situation of your latest PR first |
Made a couple of changes regarding when to check that the LOG directory actually exists.