Merged
Conversation
Added/modified code to output some trace log messages when the "_DoCleanUp_" & "_Reset_LEDs_" functions are called after the F/W Update process is completed. This should leave a trace indicating IF/WHEN the "cleanup" is done as expected, especially if the router reboots itself. This trace log is only temporary. We can switch it off later on once we have determined whether the "trap" mechanism is working after the F/W Update.
Owner
|
Haha I was just testing this. In my modification I did: And then commented out the reboot lines at the end of the curl. This was the result: syslog__TRAP_TRIGGERED_BY_Upgrade.txt |
ExtremeFiretop
added
documentation
Owner
|
One thing I noticed is the trap doesn't seem to properly/gracefully exit the script when done by control+c? Was this addressed in your PR?
|
Owner
|
Just confirmed the trap does correctly close with your PR. Maybe it was with my testing method, either way I like the extra logging so I'll merge. |
ExtremeFiretop
approved these changes
Dec 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added/modified code to output some trace log messages when the "DoCleanUp" & "Reset_LEDs" functions are called after the F/W Update process is completed. This should leave a trace indicating IF/WHEN the "cleanup" is done as expected, especially if the router reboots itself.
Creating the trace log is only temporary (/jffs/addons/MerlinAU/ MerlinAU_Trace.LOG). We can switch it off later on once we have determined whether the "trap" mechanism is working as expected.