Skip to content

Update MerlinAU.sh#60

Merged
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev
Dec 27, 2023
Merged

Update MerlinAU.sh#60
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom
Martinski4GitHub:dev

Conversation

@Martinski4GitHub
Copy link
Collaborator

Fine-tuned changes related to "interactive" sessions & exiting script.

Fine-tuned changes related to "interactive" sessions & exiting script.
@ExtremeFiretop
Copy link
Owner

Yours is better. I pick you!

@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Jan 6, 2024

@Martinski4GitHub

Unfortunantly I just tested this as a cron job and the update never went through, it gets stuck again at here:

    routerURLstr="$(_GetRouterURL_)"
    Say "Router Web URL is: ${routerURLstr}"

    if "$isInteractive"
    then
        printf "${GRNct}**IMPORTANT**:${NOct}\nThe firmware flash is about to start.\n"
        printf "Press Enter to stop now, or type ${GRNct}Y${NOct} to continue.\n"
        printf "Once started, the flashing process CANNOT be interrupted.\n"
        if ! _WaitForYESorNO_ "Continue"
        then _DoCleanUp_ 1 "$keepZIPfile" ; return 1 ; fi

I have reverted the change in the lasted PR here: #66
Logs attached for reference: GT-AXE11000_FW_Update_2024-01-06_09_45_00.log

Bring the discussion to PR #66

@Martinski4GitHub
Copy link
Collaborator Author

@Martinski4GitHub

Unfortunantly I just tested this as a cron job and the update never went through, it gets stuck again at here:

    routerURLstr="$(_GetRouterURL_)"
    Say "Router Web URL is: ${routerURLstr}"

    if "$isInteractive"
    then
        printf "${GRNct}**IMPORTANT**:${NOct}\nThe firmware flash is about to start.\n"
        printf "Press Enter to stop now, or type ${GRNct}Y${NOct} to continue.\n"
        printf "Once started, the flashing process CANNOT be interrupted.\n"
        if ! _WaitForYESorNO_ "Continue"
        then _DoCleanUp_ 1 "$keepZIPfile" ; return 1 ; fi

I have reverted the change in the lasted PR here: #66 Logs attached for reference: GT-AXE11000_FW_Update_2024-01-06_09_45_00.log

After thinking about it, I believe I have a pretty good idea of what the problem might be. It's a hypothesis ATM so I need to test & verify before I can say for sure. I'll explain once I have confirmed my hypothesis later this evening.

BTW, thanks for catching this. Another good example of why a 2nd pair of eyes is always helpful to review, test & validate code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants