Skip to content

Dev 0.2.53 Target as Next Master release#81

Merged
ExtremeFiretop merged 8 commits intomainfrom
dev
Jan 22, 2024
Merged

Dev 0.2.53 Target as Next Master release#81
ExtremeFiretop merged 8 commits intomainfrom
dev

Conversation

@ExtremeFiretop
Copy link
Owner

@ExtremeFiretop ExtremeFiretop commented Jan 22, 2024

Dev 0.2.53 Target as Next Master release
Tested successfully and confirmed both our charges today seem to work as expected.

  1. Migrate the settings folder from MerlinAU if it exists to MerlinAU.d to follow set standards.
  2. If update checks are enabled, run the webs_update.sh script before running ours.

Martinski4GitHub and others added 7 commits January 21, 2024 08:37
Added code to run a check & see if a new F/W update is available. This is done ONLY if the user has enabled F/W Update Checks; otherwise, we have to respect the user's selection not to check.
Added code to make sure we honor the user selection when choosing to disable F/W Update Checks.
@ExtremeFiretop
Copy link
Owner Author

The migration function can be removed after 2 release cycles.
Making a note that this code is just temporary to cleanup any existing installs.

@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented Jan 22, 2024

Enabled Auto-Merge for once @Martinski4GitHub approves.
Gives him a chance to squeeze in any last minute changes or concerns as this approval will push the update notification to all instances of the script.

@Martinski4GitHub
Copy link
Collaborator

The migration function can be removed after 2 release cycles. Making a note that this code is just temporary to cleanup any existing installs.

I don't think it causes any harm leaving that code longer than 2 release cycles. For example, I have read that some people have skipped one release version due to issues reported that affect their home network, so they wait for the next version. Then again, there are probably very few people (single-digit number?) who are now actively using the current "master" Auto Update script for which the migration will be necessary.

@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented Jan 22, 2024

The migration function can be removed after 2 release cycles. Making a note that this code is just temporary to cleanup any existing installs.

I don't think it causes any harm leaving that code longer than 2 release cycles. For example, I have read that some people have skipped one release version due to issues reported that affect their home network, so they wait for the next version. Then again, there are probably very few people (single-digit number?) who are now actively using the current "master" Auto Update script for which the migration will be necessary.

Agreed.

The reason I said 2 was because right now we are single digit users, but your right technically there's no harm if we leave it longer. That being said, I got the post ready for SNB when we push this out also. :)

Copy link
Collaborator

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to go, IMO.

@ExtremeFiretop ExtremeFiretop merged commit 0dd1b94 into main Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants