Skip to content

Optimizations, Steam improvements, predictive interpolation#26

Merged
Extremelyd1 merged 33 commits intoExtremelyd1:steam-p2pfrom
diamondpixel:ExtremeOptimisations
Jan 23, 2026
Merged

Optimizations, Steam improvements, predictive interpolation#26
Extremelyd1 merged 33 commits intoExtremelyd1:steam-p2pfrom
diamondpixel:ExtremeOptimisations

Conversation

@diamondpixel
Copy link
Contributor

@diamondpixel diamondpixel commented Jan 3, 2026

No description provided.

diamondpixel and others added 27 commits December 16, 2025 17:00
@diamondpixel
RTT and Reliability abstraction and more general improvements.
d00f082
@Extremelyd1
Update editorconfig with default values (Extremelyd1#21)
4b99c35
@dependabot
Bump actions/upload-artifact from 5 to 6 (Extremelyd1#18)
bbc4f97 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5 to 6.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v5...v6)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump Hamunii.BepInEx.AutoPlugin from 2.0.1 to 2.1.0 (Extremelyd1#15)
4ffaa5f 
---
updated-dependencies:
- dependency-name: Hamunii.BepInEx.AutoPlugin
  dependency-version: 2.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Extremelyd1
Resolve various issues with dependencies and the modding template (Ex…
37726b4 
…tremelyd1#22)
@diamondpixel
Merge branch 'main' into steam-p2p
36c41df
@diamondpixel
Re-formatted with projects .editorconfig
40544b7
@diamondpixel
feat: fix server-side transport capabilities, lazy-init managers
a4e1695 
- Add RequiresX capability properties to IEncryptedTransportClient
- Server-side Steam clients now correctly skip UDP sequencing logic
- Lazy-init managers only when needed (saves memory for Steam)
- Remove HolePunch stubs (to be replaced with pre-processors)
@diamondpixel
HolePunch rough
cd93b02
@diamondpixel
Added HolePunch and MasterServer
b5a225b
@diamondpixel
feat: implement comprehensive multiplayer networking, matchmaking, an…
c1d96a5 
…d lobby management system with Steam integration and some improvements to the system
@diamondpixel
Merged steam-p2p into HolePunch
8760d6a
@diamondpixel
feat: Fixed Steam's rich presence and added invite command.
6e409e5
@diamondpixel
Added missing XML comments.
0507ce6
@diamondpixel
feat; Extreme optimisations
dfdcc6d
@diamondpixel
Merge remote-tracking branch 'origin/steam-p2p' into ExtremeOptimisat…
724d914 
…ions

# Conflicts:
#	MMS/MMS.csproj
#	MMS/Models/Lobby.cs
#	MMS/Program.cs
#	MMS/Services/LobbyService.cs
#	SSMP.sln
#	SSMP/Game/Server/ModServerManager.cs
#	SSMP/Game/Settings/ModSettings.cs
#	SSMP/Game/SteamManager.cs
#	SSMP/Networking/Client/ClientTlsClient.cs
#	SSMP/Networking/Client/DtlsClient.cs
#	SSMP/Networking/Matchmaking/MmsClient.cs
#	SSMP/Networking/Server/NetServerClient.cs
#	SSMP/Networking/Server/ServerUpdateManager.cs
#	SSMP/Networking/Transport/HolePunch/HolePunchEncryptedTransport.cs
#	SSMP/Networking/Transport/HolePunch/HolePunchEncryptedTransportServer.cs
#	SSMP/Networking/Transport/SteamP2P/SteamEncryptedTransport.cs
#	SSMP/Networking/Transport/SteamP2P/SteamEncryptedTransportServer.cs
#	SSMP/Networking/UpdateManager.cs
#	SSMP/SSMP.csproj
#	SSMP/Ui/Component/LobbyConfigPanel.cs
#	SSMP/Ui/ConnectInterface.cs
@diamondpixel
feat: Minor improvements
ff8ee63
@diamondpixel
Changed Buffer.BlockCopy to Array.Copy
a62584c
@diamondpixel
feat: more fixes :)
b9b3aac
@diamondpixel
More fixes.
52183de
@diamondpixel
feat: more fixes
0b1f988
@diamondpixel
feat: Even more fixes.
c78e22a
@diamondpixel
Added proper Steam shutdown in SSMPPlugin.cs
80b21ff
@diamondpixel
Added proper Steam shutdown in GameManager.cs
56a42c7
@diamondpixel
Merge remote-tracking branch 'origin/ExtremeOptimisations' into Extre…
ae7324f 
…meOptimisations

# Conflicts:
#	SSMP/Game/GameManager.cs
@diamondpixel
Little MORE XDDD
826e3ba
@diamondpixel
changed to use existing Packet instance
67e9543
Extremelyd1
Extremelyd1 requested changes Jan 5, 2026
View reviewed changes
Copy link
Owner

@Extremelyd1 Extremelyd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments about optimizations that I think are not significantly improving memory usage. The others about various other small issues.
The reorganization of the PacketManager is much appreciated! That class was getting a bit too packed with dictionaries.

@diamondpixel
Copy link
Contributor Author

diamondpixel commented Jan 6, 2026

Greetings.

I did a bunch of testing yesterday and today. The GC allocation optimisations do drop the memory usage but eventually with enough playtime or being AFK(don't know why)the memory allocations eventually creep up to 600MB+ until I assume the GC triggers.

I tried using dotTrace and dotMemory, Visual studio profiler, Unity profiler nothing seems to be working.Moreover BepInEx's profiler is just a simple csv with thread/call counts/function/runtime/allocation and provides no clear indication of what is happening.
(One lead I have is that our Loops with ManualResetEvent, on the wait handles allocate cancellationTokens without freeing them, thus causing this leak. This has been patched in newer versions of NET 6+, but Unity have choked themselves into a corner with Mono and netstandard 2.1)

Our only left option is PerfView and I honestly don't have the knowledge and time to get to know it.

In conclusion--You can do as you please with this PR. It is not necessarily a problematic or bad pr but it doesn't solve the true problem it only masks it for X amount of time.

@diamondpixel
Copy link
Contributor Author

diamondpixel commented Jan 8, 2026 •
edited
Loading

I found sometime yesterday and modified the SimplerProfiler from BepInEx.Debug repository. I have added DLL filtering and flamegraphs and some more features to help figure out the allocations. These are my findings, i have attached a test run with SSMP and one without for reference.

For some reason we are allocating a bunch of memory with DTLS encryption / SmartCopy. But the most interesting to me is the Playmaker allocations.

PSA: After some more investigation the allocations cannot be eliminated (at least easily without trading functionality) and they are here to stay.

image image

@diamondpixel
Fixed not being able to reconnect to a lobby after quitting for Steam…
75b381a 
…. Change data send type to k_EP2PSendUnreliable from k_EP2PSendUnreliableNoDelay for better bandwidth effeciency. Updated & enabled interpolation
@Extremelyd1
Copy link
Owner

Extremelyd1 commented Jan 15, 2026

I'm assuming these changes are still worth merging even though they do not completely address the memory usage?

@diamondpixel
Copy link
Contributor Author

diamondpixel commented Jan 15, 2026

Yeah, I was playing with a friend and we noticed that Steam was really laggy. It also had issues leaving a lobby and rejoining the same one.

Extremelyd1
Extremelyd1 requested changes Jan 16, 2026
View reviewed changes
Copy link
Owner

@Extremelyd1 Extremelyd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more change requests. Also, it seems that you haven't addressed the changes from my previous review yet. See all unresolved comments please.

@Extremelyd1 Extremelyd1 changed the title Extreme optimizations Optimizations, Steam improvements, predictive interpolation Jan 23, 2026
@Extremelyd1 Extremelyd1 merged commit e7c947b into Extremelyd1:steam-p2p Jan 23, 2026
3 checks passed
@diamondpixel diamondpixel deleted the ExtremeOptimisations branch January 23, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Extremelyd1 Extremelyd1 Extremelyd1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diamondpixel @Extremelyd1