Handle large CSV files + async preprocessing#363
Draft
MatiasArriola wants to merge 11 commits into
Draft
Conversation
refactor RISIndividualFungalDataRepository.validate to accept a Blob, refactor SpreadsheetXlsxDataSource
refactor: reuse types for validation results make specimens and rows optional
…). Set PREPROCESSING_FAILED
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
yarn run async-preprocessingasync-uploadsfileSizeLimitvalue stored in dataStoreglass/generalpapaparseinstead of loading large files with the XLSX libraryCSVUtilsinstead of creating a custom repository object.ValidationResult,ValidationResultWithSpecimensAsyncImportRISIndividualFungalFileto make async-uploads work for this fileRequires dataStore changes otherwise it fall backs to defaults
TODO:
📹 Screenshots/Screen capture
🔥 Testing
dhis_2.conf:max.file_upload_size = 5120000000/usr/lib/python3.13/site-packages/d2_docker/config/nginx.conf(or check the proper path inspecting the d2-docker volume for nginx):client_max_body_size 1000m;