Skip to content

New scanner decoder with much higher performance#10

Merged
Lunkers merged 1 commit intoEyevinn:mainfrom
CarlLindqvist:decodescan
Apr 16, 2026
Merged

New scanner decoder with much higher performance#10
Lunkers merged 1 commit intoEyevinn:mainfrom
CarlLindqvist:decodescan

Conversation

@CarlLindqvist
Copy link
Copy Markdown
Contributor

@CarlLindqvist CarlLindqvist commented Apr 15, 2026

Scan decoder vs original tokenizer decoder:

  • 2.4x faster (170 us → 70 us)
  • 53% less memory (58 KB → 27 KB)
  • 53% fewer allocations (776 → 368)

Scan decoder vs encoding/xml:

  • 10.8x faster
  • 10.3x less memory
  • 18.2x fewer allocations

Copy link
Copy Markdown
Collaborator

@Lunkers Lunkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but I'd like some clarification on one thing. If we're doing unsafe pointer modifications for all the vmap strings we might run into issues here; no guarantees that the manifest URLs will fit within the original creative URLs

Comment thread vmap/decoder_scan.go
@Lunkers Lunkers merged commit 1006e85 into Eyevinn:main Apr 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants