fix: egui 0.34 panel ordering and WASM renderer#478
Merged
Conversation
With show_inside, panel rendering order determines space allocation. Bottom panels must be rendered before CentralPanel to reserve their space, otherwise CentralPanel consumes all remaining area. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
eframe 0.34 defaults to wgpu, which broke WASM renderer detection (showed "unknown") and switched to WebGPU which lacks Firefox support. - Remove cfg gate on wgpu_render_state detection so it works on WASM too - Explicitly set Renderer::Glow in WebOptions for browser compatibility Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
show_inside, bottom panels must be rendered beforeCentralPanelto reserve space#[cfg(not(wasm32))]gate on wgpu detectionRenderer::Glowfor WASM to maintain WebGL2/Firefox compatibility (eframe 0.34 defaults to wgpu)Test plan
cargo checkandtrunk buildpass clean🤖 Generated with Claude Code