Add framerate and GL passthrough properties to vision mixer#481
Merged
Add framerate and GL passthrough properties to vision mixer#481
Conversation
- Add pgm_framerate and multiview_framerate properties with broadcast standard options (23.976, 24, 25, 29.97, 30, 50, 59.94, 60 fps). Default 30 fps matching GStreamer default. - Add gl_download property to control GPU→system memory download in GPU path. When disabled, GL memory passes through to downstream blocks, avoiding unnecessary GPU→CPU→GPU roundtrips. - Remove force_live exposed property (hardcoded to true — disabling it on a live vision mixer breaks the pipeline). - Remove fakesink elements from both PGM and MV output tees in GPU and CPU paths. The tees use allow-not-linked=true and always have active consumers, making fakesinks unnecessary overhead. - Move framerate enum values to shared COMMON_VIDEO_FRAMERATES in strom-types so both vision mixer and videoformat blocks use the same list. Videoformat block updated to use fraction format with backward-compatible decimal parsing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
N/D, default30/1)gl_downloadtoggle to skip gldownload/capsfilter in the GPU pipeline, allowing GL memory passthrough to downstream blocksforce-live=trueon compositors (was always the default, now no longer user-configurable)COMMON_VIDEO_FRAMERATESandcommon_video_framerate_enum_values()intostrom-types, reused by videoformat blockTest plan
cargo test— includes newparse_framerateunit tests🤖 Generated with Claude Code